Skip to content

Fix Combined language hierarchy for ISO-only groupings#685

Open
whwan4570 wants to merge 1 commit into
masterfrom
issue-650-combined-family-overrides
Open

Fix Combined language hierarchy for ISO-only groupings#685
whwan4570 wants to merge 1 commit into
masterfrom
issue-650-combined-family-overrides

Conversation

@whwan4570

Copy link
Copy Markdown

Summary

Rebased on latest master and addresses @conradarcturus review on #651.

  • Replace reparent-children-except with explicit row-per-child entries in languageFamilyCombinedOverrides.tsv
  • Add Formosan children under fox, plus Conrad's additional ISO-only groupings (sdv, omv, sai, ssa, nic)
  • Apply overrides after Glottolog load; only Combined.parentLanguageCode is modified

Fixes #650

Supersedes #651 and #684 (same change set, now on upstream branch for deploy-preview).

Test plan

  • npm run test:runCombinedFamilyOverrides.test.ts
  • npm run lint && npm run build
  • Hierarchy UI verified locally (Combined source) — see PR comment with screenshots

Made with Cursor

Replace reparent-children-except with row-per-child TSV entries for
Formosan and Conrad's additional ISO-only groupings; load overrides after
Glottolog merge and apply only to Combined.parentLanguageCode.

Fixes #650

Co-authored-by: Cursor <cursoragent@cursor.com>
@whwan4570 whwan4570 requested a review from a team as a code owner June 23, 2026 23:00
@whwan4570

Copy link
Copy Markdown
Author

@conradarcturus Re-review requested — same code as #684, now on upstream branch so deploy-preview should pass.

Hierarchy verification (Combined source, local dev)

Base: http://localhost:5174/lang-nav/data?view=Hierarchy&languageSource=Combined&languageScopes=5,4,3,2

Group URL
Formosan (fox) open
Albanian open
Quechuan open
Basque open
Nilotic (sdv) open
Omotic (omv) open
South American Indian (sai) open
Nilo-Saharan (ssa) open
Dogon (nic) open

Screenshots captured locally (same set as #651 review): docs/pr-651-screenshots/ — 9 PNGs.

@whwan4570 whwan4570 requested a review from conradarcturus June 23, 2026 23:01
@github-actions

Copy link
Copy Markdown
Contributor

Cloudflare Pages preview

@whwan4570

Copy link
Copy Markdown
Author

Hierarchy screenshots (Combined source)

Local verification — same views as #651 review:

  1. Formosan (fox)
  2. Albanian
  3. Quechuan
  4. Basque
  5. Nilotic (sdv)
  6. Omotic (omv)
  7. South American Indian (sai)
  8. Nilo-Saharan (ssa)
  9. Dogon (nic)
01-formosan-combined-hierarchy 02-albanian-combined-hierarchy 03-quechuan-combined-hierarchy 04-basque-combined-hierarchy 05-nilotic-sdv-combined-hierarchy 06-omotic-omv-combined-hierarchy 07-sai-combined-hierarchy 08-ssa-combined-hierarchy 09-dogon-nic-combined-hierarchy

@conradarcturus conradarcturus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates from #651

This looks great! I'm not sure why cloudflare is having issues -- but you can go ahead and merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve language hierarchy when ISO has a record that Glottolog does not

2 participants