Fix Combined language hierarchy for ISO-only groupings#684
Closed
whwan4570 wants to merge 1 commit into
Closed
Conversation
Replace reparent-children-except with row-per-child TSV entries for Formosan and Conrad's additional ISO-only groupings; load overrides after Glottolog merge and apply only to Combined.parentLanguageCode. Fixes Translation-Commons#650 Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 23, 2026
Author
|
Superseded by #685 — branch moved to upstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased on latest
masterand addresses @conradarcturus review on #651.reparent-children-exceptwith explicit row-per-child entries inlanguageFamilyCombinedOverrides.tsvfox, plus Conrad's additional ISO-only groupings (sdv,omv,sai,ssa,nic)Combined.parentLanguageCodeis modifiedFixes #650
Supersedes #651 (same change set, rebased on current master).
Test plan
npm run test:run—CombinedFamilyOverrides.test.tsnpm run lint&&npm run buildMade with Cursor