Skip to content

upgrade dependency#47

Open
mohitpubnub wants to merge 3 commits into
TooTallNate:masterfrom
mohitpubnub:upgrade-deps
Open

upgrade dependency#47
mohitpubnub wants to merge 3 commits into
TooTallNate:masterfrom
mohitpubnub:upgrade-deps

Conversation

@mohitpubnub

Copy link
Copy Markdown
  • upgrade proxy-agent dependency

@mohitpubnub

Copy link
Copy Markdown
Author

@TooTallNate can we have this dependency upgraded

@robbkidd robbkidd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohitpubnub I am not a maintainer on this project, but I predict that they will not want the new files I commented on below included in the proxy-agent dependency bump.

Comment thread .DS_Store Outdated
Comment thread package-lock.json Outdated
@robbkidd

Copy link
Copy Markdown
Contributor

This PR is related to #48.

@mohitpubnub

Copy link
Copy Markdown
Author

May be it's a bit clean now!

@robbkidd

Copy link
Copy Markdown
Contributor

It's clean-er now, certainly. Thanks!

As you can see from #48, getting a release out may be more complicated than just this dependency bump.

@dargmuesli

Copy link
Copy Markdown

What would make it more complicated than an merge of this PR and a release, @robbkidd?

@robbkidd

robbkidd commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

@dargmuesli The changes in this PR are insufficient to keep superagent-proxy working with proxy-agent v6, a major version bump. This simple upgrade causes superagent-proxy to fail wiring up a proxy configuration onto superagent clients.

I have attempted to demonstrate that failure in #50, which is a duplicate of this PR's dependency bump that I applied after I fixed the tests and added a CI workflow. The new workflow is not accepted as I write this, so in the meantime you can see the failures in a demonstration on my fork. #50 now has running CI tests and shows to problem and progress toward addressing it.

Hopefully I've added enough test infrastructure for people more knowledgeable than I am about ES modules to work an update for the import.

@TooTallNate

Copy link
Copy Markdown
Owner

You're gonna have to do const { ProxyAgent } = require('proxy-agent'). There is no longer a default export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants