upgrade dependency#47
Conversation
mohitpubnub
commented
May 9, 2023
- upgrade proxy-agent dependency
|
@TooTallNate can we have this dependency upgraded |
robbkidd
left a comment
There was a problem hiding this comment.
@mohitpubnub I am not a maintainer on this project, but I predict that they will not want the new files I commented on below included in the proxy-agent dependency bump.
|
This PR is related to #48. |
|
May be it's a bit clean now! |
|
It's clean-er now, certainly. Thanks! As you can see from #48, getting a release out may be more complicated than just this dependency bump. |
|
What would make it more complicated than an merge of this PR and a release, @robbkidd? |
|
@dargmuesli The changes in this PR are insufficient to keep superagent-proxy working with proxy-agent v6, a major version bump. This simple upgrade causes superagent-proxy to fail wiring up a proxy configuration onto superagent clients. I have attempted to demonstrate that failure in #50, which is a duplicate of this PR's dependency bump that I applied after I fixed the tests and added a CI workflow. Hopefully I've added enough test infrastructure for people more knowledgeable than I am about ES modules to work an update for the import. |
|
You're gonna have to do |