[Temporarily] Removed support for Proxies on ApiClient#1
Open
cwilgenhoff wants to merge 1 commit into
Open
Conversation
cwilgenhoff
force-pushed
the
fork/remove-support-for-proxy
branch
from
b8d7953 to
90def55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This library has now a critical security flaw in a deep dependency called
vm2. You can see the chain below:superagent-proxy -> proxy-agent -> pac-proxy-agent -> pac-resolver -> degeneratorFortunately for us
proxy-agenthas been updated to not usevm2anymore but it hasn't been integrated yet tosuperagent-proxyalthough there is a PR open hereThe Cybersource SDK uses the
superagent-proxydependency to offer a way to support networks underproxies, so getting rid of that functionality will probably not be desirable for the Cybersource team.Our recomendation is therefore, to wait for the
superagent-proxylibrary to get upgraded and either raise a PR against the Cybersource SDK or talk to the CyberSource account managers to get it done for us. In the meantime, we can remove the support for proxies.Screenshots
useProxyset totrue:useProxyset tofalseor unset, and a capture token can be created with the SDK: