-
Notifications
You must be signed in to change notification settings - Fork 1
Feature - Add put action to client #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
damdl96
wants to merge
8
commits into
develop
Choose a base branch
from
feature/add-put-action-to-payee
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
790db2b
Add put action to client
damdl96 9824608
Rubocop offenses in client.rb
damdl96 ceaf145
Update action enhancements
damdl96 beed692
Language on payee#update attributes
damdl96 48abfaa
Add update action to ReadMe
damdl96 54f14d4
Update language in ReadMe
damdl96 d6fe026
ReadMe changes
damdl96 be9ca3d
Update lib/hyperwallet/api/client.rb
damdl96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,69 +1,83 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'faraday' | ||
|
|
||
| class Hyperwallet::Api::Client < Hyperwallet::Api::Config | ||
| module Hyperwallet | ||
| module Api | ||
| # Client configuration and functionalities class | ||
| class Client < Hyperwallet::Api::Config | ||
| attr_accessor :client_id, :conn, :response, :body, :errors, :previous_payload | ||
|
|
||
| attr_accessor :client_id, :conn, :response, :body, :errors, :previous_payload | ||
| def initialize | ||
| @conn = connector | ||
| add_headers | ||
| end | ||
|
|
||
| def initialize | ||
| # @client_id = client_id | ||
| @conn = get_connector | ||
| add_headers | ||
| end | ||
| def get(resource:) | ||
| self.response = conn.get do |request| | ||
| request.url resource | ||
| end | ||
| handle_response | ||
| end | ||
|
|
||
| def get(resource:) | ||
| self.response = conn.get do |request| | ||
| request.url resource | ||
| end | ||
| handle_response | ||
| end | ||
| def post(resource:, payload: nil) | ||
| @previous_payload = payload | ||
| self.response = conn.post do |request| | ||
| request.url resource | ||
| request.body = payload | ||
| end | ||
| handle_response | ||
| end | ||
|
|
||
| def post(resource:, payload: nil) | ||
| @previous_payload = payload | ||
| self.response = conn.post do |request| | ||
| request.url resource | ||
| request.body = payload | ||
| end | ||
| handle_response | ||
| end | ||
| def put(resource:, payload: nil) | ||
| @previous_payload = payload | ||
| self.response = conn.put do |request| | ||
| request.url resource | ||
| request.body = payload | ||
| end | ||
| handle_response | ||
| end | ||
|
|
||
| private | ||
| private | ||
|
|
||
| def handle_response | ||
| if self.response.success? | ||
| @body = JSON.parse(self.response.body) unless self.response.body.empty? | ||
| else | ||
| @errors = JSON.parse(self.response.body) | ||
| end | ||
| end | ||
| def handle_response | ||
| if response.success? | ||
| @body = JSON.parse(response.body) unless response.body.empty? | ||
| else | ||
| @errors = JSON.parse(response.body) | ||
| end | ||
| end | ||
|
|
||
| def get_connector | ||
| Faraday.new(url: base_url, proxy: self.class.superclass.proxy) do |conn| | ||
| conn.adapter :net_http | ||
| conn.basic_auth(self.class.superclass.api_user, self.class.superclass.api_password) | ||
| end | ||
| end | ||
| def connector | ||
| Faraday.new(url: base_url, proxy: self.class.superclass.proxy) do |conn| | ||
| conn.adapter :net_http | ||
| conn.basic_auth(self.class.superclass.api_user, self.class.superclass.api_password) | ||
| end | ||
| end | ||
|
|
||
| def request_url_for(resource) | ||
| base_url + "/" + resource | ||
| end | ||
| def request_url_for(resource) | ||
| "#{base_url}/#{resource}" | ||
| end | ||
|
|
||
| def base_url | ||
| active_url + API_VERSION | ||
| end | ||
| def base_url | ||
| active_url + API_VERSION | ||
| end | ||
|
|
||
| def active_url | ||
| if self.class.superclass.uat? | ||
| UAT_URL | ||
| elsif self.class.superclass.production? | ||
| PRODUCTION_URL | ||
| end | ||
| end | ||
| def active_url | ||
| if self.class.superclass.uat? | ||
| UAT_URL | ||
| elsif self.class.superclass.production? | ||
| PRODUCTION_URL | ||
| end | ||
| end | ||
|
|
||
| def add_headers | ||
| conn.headers.merge!( | ||
| { | ||
| 'Content-Type'=> "application/json" | ||
| } | ||
| ) | ||
| def add_headers | ||
| conn.headers.merge!( | ||
| { | ||
| 'Content-Type' => 'application/json' | ||
| } | ||
| ) | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I like the name change, changing it from
attributes_to_updatetoattributesmeans that an app using this gem would suddenly break after callingupdate. If we are sure that this method is not being used then it might be ok.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point; I don't think the method is being used, though it may cause issues in the future if we need to use it. Possibly the best is to keep it as flexible as possible.