Feature - Add put action to client#17
Open
damdl96 wants to merge 8 commits into
Open
Conversation
Sergio-e
reviewed
Oct 17, 2022
Sergio-e
reviewed
Oct 17, 2022
|
|
||
| def update(token:, attributes_to_update: ) | ||
| connector.put(resource: ENDPOINT + "/" + token, payload: JSON.generate(prepare_payload(payload_attributes: attributes_to_update))) | ||
| def update(attributes:, token: nil) |
There was a problem hiding this comment.
Though I like the name change, changing it from attributes_to_update to attributes means that an app using this gem would suddenly break after calling update. If we are sure that this method is not being used then it might be ok.
Contributor
Author
There was a problem hiding this comment.
That's a good point; I don't think the method is being used, though it may cause issues in the future if we need to use it. Possibly the best is to keep it as flexible as possible.
Co-authored-by: Sergio-e <33036058+Sergio-e@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to extend the client capabilities to support the updating elements. This PR covers:
PUTaction on the base clientpayeeclass