Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/table-core/src/utils/getFilteredRowModel.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export function getFilteredRowModel<TData extends RowData>(): (
const row = rowModel.flatRows[j]!

row.columnFilters = {}
row.columnFiltersMeta = {}

if (resolvedColumnFilters.length) {
for (let i = 0; i < resolvedColumnFilters.length; i++) {
Expand Down
69 changes: 69 additions & 0 deletions packages/table-core/tests/getFilteredRowModel.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import { describe, expect, it } from 'vitest'
import {
createColumnHelper,
createTable,
functionalUpdate,
getCoreRowModel,
getFilteredRowModel,
} from '../src'

type TestRow = {
a: string
b: string
}

describe('#getFilteredRowModel', () => {
it('clears columnFiltersMeta between filter runs so removed filter meta does not persist', () => {
const data: TestRow[] = [
{ a: 'x', b: 'y' },
{ a: 'x', b: 'z' },
]

const columnHelper = createColumnHelper<TestRow>()
const columns = [
columnHelper.accessor('a', {
id: 'a',
filterFn: (row, columnId, filterValue, addMeta) => {
addMeta?.({ from: 'a' })
return row.getValue<string>(columnId) === filterValue
},
}),
columnHelper.accessor('b', {
id: 'b',
filterFn: (row, columnId, filterValue) => {
return row.getValue<string>(columnId) === filterValue
},
}),
]

let state: any = {
columnFilters: [],
globalFilter: undefined,
}

// Create a tiny state container so `table.setColumnFilters` updates `table.options.state`
let table: ReturnType<typeof createTable<TestRow>>
table = createTable<TestRow>({
data,
columns,
renderFallbackValue: '',
getCoreRowModel: getCoreRowModel(),
getFilteredRowModel: getFilteredRowModel(),
state,
onStateChange: (updater) => {
state = functionalUpdate(updater, state)
table.setOptions((prev) => ({ ...prev, state }))
},
})

table.setColumnFilters([{ id: 'a', value: 'x' }])
const first = table.getFilteredRowModel().flatRows[0]!
expect(first.columnFiltersMeta.a).toEqual({ from: 'a' })

// Switch to a different filter that does not write meta
table.setColumnFilters([{ id: 'b', value: 'y' }])
const second = table.getFilteredRowModel().flatRows[0]!
expect(second.columnFiltersMeta.a).toBeUndefined()
})
})