Skip to content

fix(datagrid): announce grid selection to all assistive tech; label dialog controls (#1490) #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
May 30, 2026
Merged

fix(datagrid): announce grid selection to all assistive tech; label dialog controls (#1490) #1513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- VoiceOver reliability: grid selection changes are announced to all assistive technologies (not only when VoiceOver was already on), the drop and truncate dialog toggles describe their effect, and the favorite query editor is labeled. (#1490)
- Tab moves keyboard focus between the window panes (sidebar, results, inspector) by rebuilding the key view loop when the window appears. (#1490)
- The license activation sheet focuses the key field on open, the SQL review sheet closes with Escape even while the editor has focus, and the integration token sheet focuses its Done button. (#1490)
- Copy with Headers now has a default keyboard shortcut (Cmd+Option+C), so it works and is discoverable from the keyboard instead of showing in the Edit menu with no key. (#1490)
Expand Down
2 changes: 1 addition & 1 deletion TablePro/Views/Results/Selection/GridSelectionController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ final class GridSelectionController {
}

private func postAccessibilityAnnouncement(for newSelection: GridSelection) {
guard NSWorkspace.shared.isVoiceOverEnabled, let tableView else { return }
guard let tableView else { return }
let announcement: String
if newSelection.isEmpty {
announcement = String(localized: "Cell selection cleared")
Expand Down
1 change: 1 addition & 0 deletions TablePro/Views/Sidebar/FavoriteEditDialog.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ internal struct FavoriteEditDialog: View {
LabeledContent("Query") {
TextEditor(text: $query)
.font(.system(.body, design: .monospaced))
.accessibilityLabel(String(localized: "Query"))
.frame(height: 160)
.scrollContentBackground(.hidden)
.padding(4)
Expand Down
2 changes: 2 additions & 0 deletions TablePro/Views/Sidebar/TableOperationDialog.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ struct TableOperationDialog: View {
}
.toggleStyle(.checkbox)
.disabled(ignoreFKDisabled)
.accessibilityHint(String(localized: "Skips foreign key constraint checks for this operation"))

@chatgpt-codex-connector chatgpt-codex-connector Bot May 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Condition the FK hint on unsupported databases

When supportsForeignKeyDisable is false, ignoreFKDisabled disables this checkbox, but the newly added hint still tells assistive-tech users that the option “Skips foreign key constraint checks for this operation.” In that unsupported-database scenario the option cannot be selected and will remain false, so the accessible description contradicts the actual behavior; use the existing unsupported description or omit the hint while disabled.

Useful? React with 👍 / 👎.


if let description = ignoreFKDescription {
Text(description)
Expand All @@ -130,6 +131,7 @@ struct TableOperationDialog: View {
}
.toggleStyle(.checkbox)
.disabled(cascadeDisabled)
.accessibilityHint(cascadeDescription)

Text(cascadeDescription)
.font(.subheadline)
Expand Down
Loading