fix(datagrid): announce grid selection to all assistive tech; label dialog controls (#1490)#1513
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee3ef42498
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| .toggleStyle(.checkbox) | ||
| .disabled(ignoreFKDisabled) | ||
| .accessibilityHint(String(localized: "Skips foreign key constraint checks for this operation")) |
There was a problem hiding this comment.
When supportsForeignKeyDisable is false, ignoreFKDisabled disables this checkbox, but the newly added hint still tells assistive-tech users that the option “Skips foreign key constraint checks for this operation.” In that unsupported-database scenario the option cannot be selected and will remain false, so the accessible description contradicts the actual behavior; use the existing unsupported description or omit the hint while disabled.
Useful? React with 👍 / 👎.
1 participant
Part of #1490 (keyboard, focus, accessibility). VoiceOver polish.
NSWorkspace.shared.isVoiceOverEnabledguard inGridSelectionController.postAccessibilityAnnouncement.NSAccessibility.postis only delivered to running assistive technologies anyway, so the guard added nothing and excluded non-VoiceOver AT (Switch Control, etc.) and the case where VoiceOver is enabled mid-session..accessibilityHinton the 'Ignore foreign key checks' and 'Cascade' toggles describing the consequence..accessibilityLabel("Query")on the queryTextEditor(it had no adjacent field label for VoiceOver).Additive, no behavior change for sighted users. Lint clean, style gate clean.