Skip to content

feat(generic): data-aria-* attrs → aria-* attrs#645

Merged
wesleyboar merged 3 commits into
mainfrom
feat/promote-data-aria-attributes
Jun 8, 2026
Merged

feat(generic): data-aria-* attrs → aria-* attrs#645
wesleyboar merged 3 commits into
mainfrom
feat/promote-data-aria-attributes

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Jun 8, 2026

Copy link
Copy Markdown
Member

Overview

ES module to overcome Core-CMS WYSIWYG deleting aria-* attributes.

Related

Changes

  • adds script

Testing

Test TACC/Core-CMS#1169 still works via TACC/tup-ui#558 using new module hack.

<script type="module">
+ import promoteDataAriaAttributes from 'https://cdn.jsdelivr.net/gh/TACC/Core-Styles@feat/promote-data-aria-attributes/src/lib/_utils/js/promote-data-aria-attributes.js';
  import sortableTable from 'https://cdn.jsdelivr.net/gh/TACC/Core-CMS@58e0875e/taccsite_cms/static/site_cms/js/modules/sortableTable.js';

  const scopeElement = document.getElementById('cms-content');

+ promoteDataAriaAttributes(scopeElement);
  sortableTable({
    scopeElement,
    buttonClass: 'btn btn-link',
  });
</script>

Tip

Still works!

UI

Skipped.

wesleyboar and others added 3 commits June 8, 2026 12:52
Editors that strip aria-* on publish can keep data-aria-*; callers run this
once on a scope root before scripts that depend on real ARIA attributes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@wesleyboar wesleyboar changed the title Feat/promote data aria attributes feat: convert data-aria-* attrs to aria-* attrs Jun 8, 2026
@wesleyboar wesleyboar changed the title feat: convert data-aria-* attrs to aria-* attrs feat(generic): data-aria-* attrs → aria-* attrs Jun 8, 2026
@wesleyboar wesleyboar merged commit 5fe56f0 into main Jun 8, 2026
@wesleyboar wesleyboar deleted the feat/promote-data-aria-attributes branch June 8, 2026 19:08
wesleyboar added a commit to TACC/Core-CMS-Custom that referenced this pull request Jun 8, 2026
## Overview

ES module for Core CMS WYSIWYG HTML that copies `data-aria-*` to
`aria-*` on a scope root before other scripts run.

## Related

- moves TACC/Core-Styles#645
- supports testing TACC/tup-ui#558

## Changes

- **added** `generic_assets/js/promote-data-aria-attributes.js`

## Testing

1. After merge, import from jsDelivr on this repo (pin commit hash).
2. Confirm sortable table / ARIA behavior still works per
TACC/tup-ui#558.

## UI

Skipped.

Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar added a commit that referenced this pull request Jun 8, 2026
## Overview

Removes `promote-data-aria-attributes` from Core-Styles; the module
lives in Core-CMS-Custom `generic_assets` instead.

## Related

- reverts #645
- moves to TACC/Core-CMS-Custom#539

## Changes

- **deleted** `src/lib/_utils/js/promote-data-aria-attributes.js`

## Testing

1. Confirm file is absent after merge.
2. Point consumers at Core-CMS-Custom jsDelivr URL (see companion PR).

## UI

Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant