feat(generic): data-aria-* attrs → aria-* attrs#539
Merged
Conversation
Editors that strip aria-* on publish can keep data-aria-*; callers run this once on a scope root before scripts that depend on real ARIA attributes. Relates-to TACC/Core-Styles#645 Co-authored-by: Cursor <cursoragent@cursor.com>
wesleyboar
added a commit
to TACC/Core-Styles
that referenced
this pull request
Jun 8, 2026
## Overview Removes `promote-data-aria-attributes` from Core-Styles; the module lives in Core-CMS-Custom `generic_assets` instead. ## Related - reverts #645 - moves to TACC/Core-CMS-Custom#539 ## Changes - **deleted** `src/lib/_utils/js/promote-data-aria-attributes.js` ## Testing 1. Confirm file is absent after merge. 2. Point consumers at Core-CMS-Custom jsDelivr URL (see companion PR). ## UI Skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ES module for Core CMS WYSIWYG HTML that copies
data-aria-*toaria-*on a scope root before other scripts run.Related
Changes
generic_assets/js/promote-data-aria-attributes.jsTesting
UI
Skipped.