Fix probe metadata and annotations retention #26
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, everyone!
I noticed that when converting a probe from
probeinterface/Probetondx-probeinterface/Probeand then back toprobeinterface/Probesome metadata (name,manufacturer,serial_number,model_name) are lost.This is due to the
to_probeinterface()method and I fixed it by assigning these attributes to the newprobeinterface/Probeobject.More in general,
annotationsare not stored in thendx-probeinterface/Probeobject, thus they are not rewritten in the recoveredprobeinterface/Probeobject.Currently, this pull request fixes only the first issue concerning probe metadata, as they are saved as attributes of the
ndx-probeinterface/Probeobject. To my understanding, the retention ofannotationsin general would require some changes in thendx-probeinterface/Probeclass specification, making this task a bit more complex.