Fix probe metadata and annotations retention #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alejoe91 would you mind accepting the pull request if everything is in order? :) |
Member
|
@FrancescoNegri can you add the annotation read/write to the tests to make sure it's working properly? |
Contributor
Author
|
Sure!! I can do that tomorrow! 👍 |
Contributor
Author
|
@alejoe91 I added the tests. Please check what I did and let me know if it is correct, as I am quite new at unit testing! |
alejoe91
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to close #26, therefore I opened a new pull request here.