-
Notifications
You must be signed in to change notification settings - Fork 720
SONARJAVA-6028 fix FP for rule S1120 raising on compact source files #5433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rombirli
merged 2 commits into
master
from
rombirli/SONARJAVA-6028-FPS1120-raising-compactsourcefile
Feb 5, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 23 additions & 5 deletions
28
java-checks-test-sources/default/src/main/java/checks/IndentationCheck_compactSource.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,29 @@ | ||
| // SONARJAVA-6028: FPs ahead. Only the line with "Too much." should be noncompliant. | ||
|
|
||
| void main() { // Noncompliant | ||
| System.out.println("Just right."); // Noncompliant | ||
| void main() { | ||
| System.out.println("Just right."); | ||
| if (true) { | ||
| System.out.println("Too much."); // Noncompliant | ||
| } | ||
| } | ||
|
|
||
| class MyClass { // Noncompliant | ||
| class MyClass { | ||
| void myMethod() { | ||
| System.err.println("Error message"); | ||
| } | ||
|
|
||
| static private class MyNestedClass { | ||
| private final static int VALUE = 42; | ||
| public float pi = 3.14f; | ||
| public String badlyIndentedField = "Oops"; // Noncompliant | ||
| public String secondBadlyIndentedField = "Oops x 2"; // Compliant, raised on previous line | ||
|
|
||
|
|
||
| void anotherMethod() { | ||
| System.out.println("Nested class output"); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| int i = 0; | ||
| public String badlyIndentedField = "Oops"; // Noncompliant | ||
| public String secondBadlyIndentedField = "Oops x 2"; // Compliant, raised on previous line | ||
| int j = 0; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add some more stuff in this test file, some local fields, nested class, some more methods.