Skip to content

SONARJAVA-6028 fix FP for rule S1120 raising on compact source files#5433

Merged
rombirli merged 2 commits intomasterfrom
rombirli/SONARJAVA-6028-FPS1120-raising-compactsourcefile
Feb 5, 2026
Merged

SONARJAVA-6028 fix FP for rule S1120 raising on compact source files#5433
rombirli merged 2 commits intomasterfrom
rombirli/SONARJAVA-6028-FPS1120-raising-compactsourcefile

Conversation

@rombirli
Copy link
Contributor

@rombirli rombirli commented Feb 4, 2026

No description provided.

@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Feb 4, 2026

SONARJAVA-6028

@@ -1,11 +1,11 @@
// SONARJAVA-6028: FPs ahead. Only the line with "Too much." should be noncompliant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, we can remove this comment :)

}

class MyClass { // Noncompliant
class MyClass {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some more stuff in this test file, some local fields, nested class, some more methods.

@sonarqube-next
Copy link

sonarqube-next bot commented Feb 4, 2026

@rombirli rombirli merged commit 2454088 into master Feb 5, 2026
18 checks passed
@rombirli rombirli deleted the rombirli/SONARJAVA-6028-FPS1120-raising-compactsourcefile branch February 5, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants