Skip to content

ci: label pull requests with database migrations#766

Merged
Soju06 merged 3 commits into
Soju06:mainfrom
Komzpa:chore/db-migration-label
May 24, 2026
Merged

ci: label pull requests with database migrations#766
Soju06 merged 3 commits into
Soju06:mainfrom
Komzpa:chore/db-migration-label

Conversation

@Komzpa
Copy link
Copy Markdown
Collaborator

@Komzpa Komzpa commented May 21, 2026

Summary

  • add a db migration path label for Alembic revision changes
  • run actions/labeler on pull requests from forks without checking out PR code
  • keep manual labels stable by disabling label sync/removal

Why

Merging several green PRs that each add database migrations needs maintainer ordering/oversight even when CI is green.

Test plan

@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 21, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 21, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 21, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 21, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 21, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 21, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 22, 2026

확인했습니다. 전체 방향은 맞고 CI/merge 상태도 좋습니다.

다만 merge 전에 한 가지는 고치는 게 좋겠습니다.

Blocker / 수정 권장

.github/workflows/pr-labeler.yml:16

uses: actions/labeler@v6.0.1

이 repo의 기존 workflow들은 대부분 third-party Actions를 SHA로 pin하고 있고, 이 workflow는 pull_request_target + pull-requests: write 권한을 갖습니다. 그래서 tag pin보다는 immutable SHA pin이 맞습니다. zizmor도 high로 잡습니다:

error[unpinned-uses]: unpinned action reference
  --> .github/workflows/pr-labeler.yml:16:15
   |
16 |         uses: actions/labeler@v6.0.1
   |               ^^^^^^^^^^^^^^^^^^^^^^ action is not pinned to a hash (required by blanket policy)

현재 v6.0.1 tag SHA는 아래로 확인했습니다:

uses: actions/labeler@634933edcd8ababfe52f92936142cc22ac488b1b

그 외 caveat: pull_request_target workflow를 새로 추가하는 PR이라 이 PR 자체에서는 새 labeler workflow가 base branch에 아직 없어 실제 동작 검증이 어렵고, merge 후 다음 PR부터 검증됩니다.

@Soju06 Soju06 added the hermes: needs-followup Hermes left a blocker/comment that needs follow-up observation label May 22, 2026
@Komzpa Komzpa removed 🤖 codex: ok [@codex review] says no issues found. hermes: needs-followup Hermes left a blocker/comment that needs follow-up observation labels May 22, 2026
@Komzpa
Copy link
Copy Markdown
Collaborator Author

Komzpa commented May 22, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa added 🤖 codex: ok [@codex review] says no issues found. and removed 🤖 codex: ok [@codex review] says no issues found. labels May 22, 2026
@Komzpa Komzpa force-pushed the chore/db-migration-label branch from dd7f76f to f1357bf Compare May 22, 2026 15:44
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 22, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 22, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Soju06 Soju06 removed the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Soju06
Copy link
Copy Markdown
Owner

Soju06 commented May 23, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 23, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 24, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 24, 2026
@Komzpa Komzpa removed the 🤖 codex: ok [@codex review] says no issues found. label May 24, 2026
@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label May 24, 2026
@Soju06 Soju06 merged commit 1ccc4e6 into Soju06:main May 24, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 codex: ok [@codex review] says no issues found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants