Skip to content

update release workflow to keep the dashboard and core image names in lower case #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Adhish-Krishna merged 3 commits into from
Feb 27, 2026
Merged

update release workflow to keep the dashboard and core image names in lower case #6

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af1cbbb
update release workflow to keep the dashboard and core image names in…
Adhish-Krishna Feb 27, 2026
fabd522
Initial plan
Copilot Feb 27, 2026
920a8e2
Merge pull request #7 from SimpleNotificationSystem/copilot/sub-pr-6
Adhish-Krishna Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,9 @@ jobs:
VERSION="${{ steps.get_tag.outputs.version }}"
TAG="${{ steps.get_tag.outputs.tag }}"
PREV_TAG="${{ steps.prev_tag.outputs.prev_tag }}"
OWNER_LOWER=$(echo "${{ github.repository_owner }}" | tr '[:upper:]' '[:lower:]')
CORE_IMAGE="${{ env.REGISTRY }}/${OWNER_LOWER}/simplens-core"
DASHBOARD_IMAGE="${{ env.REGISTRY }}/${OWNER_LOWER}/simplens-dashboard"
Comment on lines +67 to +69
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORE_IMAGE/DASHBOARD_IMAGE are now computed from a lower-cased owner, but the workflow still defines env.CORE_IMAGE_NAME / env.DASHBOARD_IMAGE_NAME at the top using ${{ github.repository_owner }} (not lower-cased) and they’re now unused. To avoid drift and to fully achieve the “image names in lower case” goal, either update those env values to use a lower-cased owner (e.g., via an Actions expression) and keep using them here, or remove the unused env vars entirely and document these as the single source of truth.

Copilot uses AI. Check for mistakes.

# Get commits
if [ -z "$RANGE" ]; then
Expand Down Expand Up @@ -126,12 +129,12 @@ jobs:
BODY="$BODY## 🐳 Docker Images"$'\n\n'
BODY="$BODY| Service | Image |"$'\n'
BODY="$BODY|---------|-------|"$'\n'
BODY="$BODY| Core | \`${{ env.REGISTRY }}/${{ env.CORE_IMAGE_NAME }}:$VERSION\` |"$'\n'
BODY="$BODY| Dashboard | \`${{ env.REGISTRY }}/${{ env.DASHBOARD_IMAGE_NAME }}:$VERSION\` |"$'\n\n'
BODY="$BODY| Core | \`${CORE_IMAGE}:$VERSION\` |"$'\n'
BODY="$BODY| Dashboard | \`${DASHBOARD_IMAGE}:$VERSION\` |"$'\n\n'
BODY="$BODY\`\`\`bash"$'\n'
BODY="$BODY# Pull images for this release"$'\n'
BODY="${BODY}docker pull ${{ env.REGISTRY }}/${{ env.CORE_IMAGE_NAME }}:$VERSION"$'\n'
BODY="${BODY}docker pull ${{ env.REGISTRY }}/${{ env.DASHBOARD_IMAGE_NAME }}:$VERSION"$'\n'
BODY="${BODY}docker pull ${CORE_IMAGE}:$VERSION"$'\n'
BODY="${BODY}docker pull ${DASHBOARD_IMAGE}:$VERSION"$'\n'
BODY="$BODY\`\`\`"$'\n'

# Save to file (to handle multiline output)
Expand Down