update release workflow to keep the dashboard and core image names in lower case#6
update release workflow to keep the dashboard and core image names in lower case#6Adhish-Krishna merged 3 commits intomasterfrom
Conversation
|
@copilot review this pr and then approve it if it is safe |
|
@Adhish-Krishna I've opened a new pull request, #7, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Release workflow to ensure the Docker image references included in autogenerated release notes use a lower-cased repository owner (to match GHCR naming constraints).
Changes:
- Derive a lower-cased repository owner in the release-notes generation step.
- Build
CORE_IMAGE/DASHBOARD_IMAGEstrings from the lower-cased owner and use them in the Docker Images section and pull commands.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OWNER_LOWER=$(echo "${{ github.repository_owner }}" | tr '[:upper:]' '[:lower:]') | ||
| CORE_IMAGE="${{ env.REGISTRY }}/${OWNER_LOWER}/simplens-core" | ||
| DASHBOARD_IMAGE="${{ env.REGISTRY }}/${OWNER_LOWER}/simplens-dashboard" |
There was a problem hiding this comment.
CORE_IMAGE/DASHBOARD_IMAGE are now computed from a lower-cased owner, but the workflow still defines env.CORE_IMAGE_NAME / env.DASHBOARD_IMAGE_NAME at the top using ${{ github.repository_owner }} (not lower-cased) and they’re now unused. To avoid drift and to fully achieve the “image names in lower case” goal, either update those env values to use a lower-cased owner (e.g., via an Actions expression) and keep using them here, or remove the unused env vars entirely and document these as the single source of truth.
Review: release workflow lowercase Docker image names
No description provided.