Skip to content

Fix hydrogen upgrade failing with yarn #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdaviduik merged 5 commits into from
Mar 17, 2026
Merged

Fix hydrogen upgrade failing with yarn #3462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a8d6b3b
Fix hydrogen upgrade failing with yarn
umxr Feb 11, 2026
53f1483
Fix pnpm command mapping to use 'add' instead of 'install'
umxr Mar 3, 2026
61fc87e
Extract resolvePackageManagerName helper
umxr Mar 3, 2026
1172494
docs: update changeset to mention both yarn and pnpm fix
umxr Mar 3, 2026
9ac212e
docs: add comment explaining why installNodeModules was replaced
umxr Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-yarn-upgrade-command.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/cli-hydrogen': patch
---

Fix `hydrogen upgrade` failing with yarn and pnpm by using the correct package-specific install subcommand (`add` for yarn/pnpm, `install` for npm/bun) when upgrading dependencies
44 changes: 33 additions & 11 deletions packages/cli/src/commands/hydrogen/upgrade.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
} from '@shopify/cli-kit/node/fs';
import {
getDependencies,
installNodeModules,
getPackageManager,
type PackageJson,
} from '@shopify/cli-kit/node/node-package-manager';
Comment thread
kdaviduik marked this conversation as resolved.
Expand Down Expand Up @@ -892,7 +891,9 @@ export async function upgradeNodeModules({
});
}

// Then install/upgrade dependencies
// Install/upgrade dependencies using exec() directly instead of cli-kit's
// installNodeModules(), which runs `<pm> install` and doesn't support adding
// specific packages with version specifiers (yarn/pnpm require `add`).
const upgradeArgs = buildUpgradeCommandArgs({
selectedRelease,
currentDependencies,
Expand All @@ -903,11 +904,24 @@ export async function upgradeNodeModules({
tasks.push({
title: `Upgrading dependencies`,
task: async () => {
await installNodeModules({
directory: appPath,
packageManager: await getPackageManager(appPath),
args: upgradeArgs,
});
const packageManager = await getPackageManager(appPath);
const command =
packageManager === 'npm'
? 'install'
: packageManager === 'yarn'
? 'add'
: packageManager === 'pnpm'
? 'add'
: packageManager === 'bun'
? 'install'
: 'install'; // fallback to npm for 'unknown'
await exec(
resolvePackageManagerName(packageManager),
[command, ...upgradeArgs],
{
cwd: appPath,
},
);
},
});
}
Expand All @@ -917,6 +931,15 @@ export async function upgradeNodeModules({
}
}

/**
* Normalizes the package manager name, falling back to npm for 'unknown'.
*/
function resolvePackageManagerName(
packageManager: 'npm' | 'yarn' | 'pnpm' | 'unknown' | 'bun',
): 'npm' | 'yarn' | 'pnpm' | 'bun' {
return packageManager === 'unknown' ? 'npm' : packageManager;
}

/**
* Uninstalls the specified dependencies
*/
Expand All @@ -942,10 +965,9 @@ async function uninstallNodeModules({
? 'remove'
: 'uninstall'; // fallback to npm for 'unknown'

const actualPackageManager =
packageManager === 'unknown' ? 'npm' : packageManager;

await exec(actualPackageManager, [command, ...args], {cwd: directory});
await exec(resolvePackageManagerName(packageManager), [command, ...args], {
cwd: directory,
});
}

/**
Expand Down
Loading