Fix hydrogen upgrade failing with yarn and pnpm #3462
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade command was using `installNodeModules` which always runs `<pm> install <packages>`. This works for npm but fails for yarn, pnpm, and bun which require `add` instead of `install` when adding/upgrading specific packages. Mirror the pattern already used by `uninstallNodeModules` which correctly maps the subcommand per package manager.
umxr
force-pushed
the
fix/yarn-upgrade-command
branch
from
9afba8b to
8404465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hydrogen upgradecommand was usinginstallNodeModules()from cli-kit, which always runs<pm> install <packages>. This works for npm but fails for yarn, pnpm, and bun, which requireaddinstead ofinstallwhen adding/upgrading specific packages.exec()call that maps the correct subcommand per package manager (installfor npm,addfor yarn/pnpm/bun), mirroring the pattern already used byuninstallNodeModules()in the same file.Error before fix
Test plan
upgradeNodeModulesandbuildUpgradeCommandArgstests passshopify hydrogen upgradein a yarn-based Hydrogen projectshopify hydrogen upgradein an npm-based Hydrogen project (no regression)