Skip to content

fix: create address section not shown when customer has zero addresses #3456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredericoo merged 4 commits into from
Feb 16, 2026
Merged

fix: create address section not shown when customer has zero addresses #3456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f866c9
fix: create address section not shown when customer has zero addresses
fredericoo Feb 9, 2026
551331c
chore: changeset
fredericoo Feb 9, 2026
a0ac9f7
feat: reset new address form when addresses change
fredericoo Feb 10, 2026
fc12d1f
fix: changeset
fredericoo Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/rotten-mugs-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
Copy link
Copy Markdown
Contributor

@kdaviduik kdaviduik Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(threading)

I think the form should be cleared upon successful submission. But definitely not cleared if there is an error. When I created my address it kept the form populated which felt odd

Copy link
Copy Markdown
Contributor Author

@fredericoo fredericoo Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added key to the new address form as the number of addresses we have – this is a quick way to lose state when it works.

the tradeoff is that if you fill it, then delete an address, it’ll be cleared too

but this does make it a nicer experience in general, and improving creation of addresses is not the scope of this PR

'skeleton': patch
'@shopify/cli-hydrogen': patch
---

Fixed an issue where users without addresses could not add the first one
1 change: 1 addition & 0 deletions _test
Open in desktop
Submodule _test added at f8a2db
24 changes: 12 additions & 12 deletions templates/skeleton/app/routes/account.addresses.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,23 +264,23 @@ export default function Addresses() {
<div className="account-addresses">
<h2>Addresses</h2>
<br />
{!addresses.nodes.length ? (
<p>You have no addresses saved.</p>
) : (
<div>
<div>
<div>
<legend>Create address</legend>
<NewAddressForm />
</div>
<br />
<hr />
<br />
<legend>Create address</legend>
<NewAddressForm key={addresses.nodes.length} />
</div>
<br />
<hr />
<br />
{!addresses.nodes.length ? (
<p>You have no addresses saved.</p>
) : (
<ExistingAddresses
addresses={addresses}
defaultAddress={defaultAddress}
/>
</div>
)}
)}
</div>
</div>
);
}
Expand Down
Loading