fix: create address section not shown when customer has zero addresses#3456
fix: create address section not shown when customer has zero addresses#3456fredericoo merged 4 commits intomainfrom
Conversation
fredericoo
force-pushed
the
fb-fix-customer-addresses
branch
from
24871eb to
0f866c9
Compare
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
(threading)
I think the form should be cleared upon successful submission. But definitely not cleared if there is an error. When I created my address it kept the form populated which felt odd
There was a problem hiding this comment.
added key to the new address form as the number of addresses we have – this is a quick way to lose state when it works.
the tradeoff is that if you fill it, then delete an address, it’ll be cleared too
but this does make it a nicer experience in general, and improving creation of addresses is not the scope of this PR
kdaviduik
left a comment
kdaviduik
left a comment
There was a problem hiding this comment.
LGTM, CI seems to be failing for the changeset, please look into that and fix it before merging
Merge activity
|
3 participants
users with zero addresses were unable to create addresses