Skip to content

Classify webhook subscription modules as configuration experience #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacroldan wants to merge 1 commit into
base: deploy-split/01-cli-kit-order-insensitive-compare
Choose a base branch
from
+6 −4
Open

Classify webhook subscription modules as configuration experience #8045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions packages/app/src/cli/utilities/developer-platform-client/app-management-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ import {
AppLogsSubscribeMutationVariables,
} from '../../api/graphql/app-management/generated/app-logs-subscribe.js'
import {SourceExtension} from '../../api/graphql/app-management/generated/types.js'
import {WebhookSubscriptionSpecIdentifier} from '../../models/extensions/specifications/app_config_webhook_subscription.js'
import {fetchOrganizations} from '@shopify/organizations'
import {getAppAutomationToken} from '@shopify/cli-kit/node/environment'
import {ensureAuthenticatedAppManagementAndBusinessPlatform, Session} from '@shopify/cli-kit/node/session'
Expand Down Expand Up @@ -445,7 +446,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
managementExperience: 'cli',
registrationLimit: spec.uidStrategy.appModuleLimit,
uidStrategy: uidStrategyFromTypename(spec.uidStrategy.__typename),
experience: normalizeExperience(spec.experience),
experience: normalizeExperience(spec.experience, spec.identifier),
validationSchema: spec.validationSchema,
}),
)
Expand Down Expand Up @@ -687,7 +688,7 @@ export class AppManagementClient implements DeveloperPlatformClient {
registrationTitle: mod.handle,
specification: {
identifier: mod.specification.identifier,
experience: normalizeExperience(mod.specification.experience),
experience: normalizeExperience(mod.specification.experience, mod.specification.identifier),
options: {
managementExperience: 'cli',
},
Expand Down Expand Up @@ -1364,7 +1365,8 @@ type SpecificationExperience = 'extension' | 'configuration' | 'deprecated'
* Normalizes the raw experience string from the API into a known union value.
* Falls back to 'extension' for any unexpected/unknown values and logs a debug message.
*/
function normalizeExperience(raw: string): SpecificationExperience {
function normalizeExperience(raw: string, type: string): SpecificationExperience {
if (type === WebhookSubscriptionSpecIdentifier) return 'configuration'
switch (raw) {
case 'extension':
case 'configuration':
Expand Down Expand Up @@ -1422,7 +1424,7 @@ function appModuleVersion(mod: ReleasedAppModuleFragment): Required<AppModuleVer
...mod.specification,
identifier: mod.specification.identifier,
options: {managementExperience: mod.specification.managementExperience as 'cli' | 'custom' | 'dashboard'},
experience: normalizeExperience(mod.specification.experience),
experience: normalizeExperience(mod.specification.experience, mod.specification.externalIdentifier),
},
}
}
Expand Down
Loading