Classify webhook subscription modules as configuration experience#8045
Open
isaacroldan wants to merge 1 commit into
Open
Conversation
`normalizeExperience` now receives the spec identifier and maps the webhook subscription spec to the `configuration` experience. This makes the active-app-version deploy/release classification (added later in this stack) treat webhook subscriptions as configuration rather than extensions. No consumer relies on the new classification yet, so behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The active-app-version classification (#8055) derives each module's create/update/delete status from its
experience. Webhook subscription modules must be treated as configuration, not standalone extensions, or they surface incorrectly in the deploy prompt.WHAT is this pull request doing?
normalizeExperiencenow receives the spec identifier and maps the webhook subscription spec to theconfigurationexperience. Private function; all three call sites updated in-file. No consumer reads the new classification yet, so behavior is unchanged.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/utilities/developer-platform-client/app-management-client.test.ts