Skip to content

Move preview store name into card body instead of a single-row table #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcaplan merged 1 commit into from
Jun 25, 2026
Merged

Move preview store name into card body instead of a single-row table #7925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/store/src/cli/services/store/create/preview/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('preview store create service', () => {
expect(result).toEqual({
status: 'success',
message:
'Your Shopify store is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
'Your Shopify store "Lavender Candles" is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
store: {
id: '123',
name: 'Lavender Candles',
Expand Down
3 changes: 1 addition & 2 deletions packages/store/src/cli/services/store/create/preview/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ async function persistPreviewStoreSession(

return {
status: 'success',
message:
'Your Shopify store is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
message: `Your Shopify store "${response.shop.name}" is ready. This store is temporary. Create a free Shopify account to save it and start selling.`,
store: {
id: response.shop.id,
name: response.shop.name,
Expand Down
12 changes: 3 additions & 9 deletions packages/store/src/cli/services/store/create/preview/result.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ vi.mock('@shopify/cli-kit/node/ui', async () => {
const result = {
status: 'success' as const,
message:
'Your Shopify store is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
'Your Shopify store "Lavender Candles" is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
store: {
id: '123',
name: 'Lavender Candles',
Expand All @@ -34,7 +34,7 @@ describe('preview store create result presenter', () => {
{
status: 'success',
message:
'Your Shopify store is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
'Your Shopify store "Lavender Candles" is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
store: {
id: '123',
name: 'Lavender Candles',
Expand Down Expand Up @@ -62,13 +62,7 @@ describe('preview store create result presenter', () => {
headline: 'Store created',
customSections: [
{
body: {
tabularData: [['Name', 'Lavender Candles']],
firstColumnSubdued: true,
},
},
{
body: 'Your Shopify store is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
body: 'Your Shopify store "Lavender Candles" is ready. This store is temporary. Create a free Shopify account to save it and start selling.',
},
{
title: 'Next steps',
Expand Down
6 changes: 0 additions & 6 deletions packages/store/src/cli/services/store/create/preview/result.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ function renderTextResult(result: CreatePreviewStoreResult): void {
// eslint-disable-next-line @shopify/cli/banner-headline-format
headline: 'Store created',
customSections: [
{
body: {
tabularData: [['Name', result.store.name]],
firstColumnSubdued: true,
},
},
{
body: result.message,
},
Expand Down
Loading