Move preview store name into card body instead of a single-row table#7925
Merged
Conversation
The "Store created" card showed the store name in a one-row table, which looks awkward. Fold the name into the body copy (Your Shopify store "<name>" is ready...) so it reads naturally and stays less emphasized — important since auto-generated names like "My Store" would look odd in the title. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
no-changelog
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the preview-store creation success output by removing the awkward single-row “Name” table and instead incorporating the store name directly into the success message body copy, while keeping the “Store created” headline unchanged.
Changes:
- Interpolates the preview store name into the returned
messagestring (affecting both text and JSON outputs). - Removes the
tabularDatacustom section that previously rendered the store name as a one-row table. - Updates service/presenter tests to assert the new wording and section structure.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/store/src/cli/services/store/create/preview/result.ts | Drops the single-row tabular “Name” section; renders the success card message body directly. |
| packages/store/src/cli/services/store/create/preview/result.test.ts | Updates presenter expectations for the new message text and removed table section. |
| packages/store/src/cli/services/store/create/preview/index.ts | Updates the success message to include the created store name via interpolation. |
| packages/store/src/cli/services/store/create/preview/index.test.ts | Updates the service-level expected message string to match the new wording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alfonso-noriega
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a preview store is created, the success card rendered the store name in a one-row table:
A single-row table looks awkward. This folds the name into the body copy instead, keeping the
Store createdtitle:Why
Per the design discussion: keep the title de-emphasized so auto-generated names (e.g.
My Store) don't get title-level emphasis, and surface the name in the less-emphasized body text instead.Changes
index.ts: resultmessagenow interpolates the store name —Your Shopify store "<name>" is ready. ...(flows into both text and JSON output).result.ts: removed the single-rowtabularDatasection;Store createdheadline unchanged.No changeset — preview-store work isn't public yet.
🤖 Generated with Claude Code