Document pre-submit workflow and local dev (AGENTS.md + docs/LOCAL_DEV.md)#7734
Draft
dmerand wants to merge 3 commits into
Draft
Document pre-submit workflow and local dev (AGENTS.md + docs/LOCAL_DEV.md)#7734dmerand wants to merge 3 commits into
dmerand wants to merge 3 commits into
Conversation
github-actions
Bot
added
the
no-changelog
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Contributors and agents had no written guidance on getting a change green in CI, which checks to run before pushing, or local-dev conventions — all rediscovered per session. Agent instructions were also split across
.claude/CLAUDE.mdand.cursor/rules/with no single entry point.WHAT is this pull request doing?
AGENTS.md(root) is now the source of truth for agent/contributor instructions: it keeps the existing.cursor/rulesreferences and adds the pre-submit workflow —pnpm pre-cibefore pushing,pnpm codegenafter command/flag/query changes,pnpm lint(noteslint <file>; CI lints project sources, notbin/), where custom lint rules live, and tests. LinksCONTRIBUTING.mdanddocs/LOCAL_DEV.md..claude/CLAUDE.mdbecomes a symlink to../AGENTS.md, so Claude and AGENTS.md-aware tools read the same file.docs/LOCAL_DEV.md: setup viadev up, running the CLI, the local service env (SHOPIFY_SERVICE_ENV=local,SHOPIFY_CLI_NEVER_USE_PARTNERS_API=1), local admin URL mapping (fqdn.ts), and a theme-check pointer.Docs only.
How to test your changes?
Read-through. Cited facts are verified in source:
cli-kitenv constants, theadmin.shop.devmapping inpackages/cli-kit/src/public/node/context/fqdn.ts, and custom rules inpackages/eslint-plugin-cli/rules/. Confirm Claude Code resolves the@.cursor/rules/*imports through the.claude/CLAUDE.mdsymlink.Post-release steps
None.