Single-source codegen freshness checks via pnpm codegen scripts#7732
Draft
dmerand wants to merge 2 commits into
Draft
Single-source codegen freshness checks via pnpm codegen scripts#7732dmerand wants to merge 2 commits into
dmerand wants to merge 2 commits into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The two generated-file gates (
Check graphql-codegen has been run,Check OCLIF manifests & readme & docs) inline their regenerate-and-verify steps intests-pr.yml. No local command runs the same steps, so staleness surfaces only as a CI failure and gets fixed piecemeal. The regeneration list lives in both the workflow and contributors' memory, so the two drift.WHAT is this pull request doing?
package.jsonbecomes the single source of codegen freshness, used by humans and CI:pnpm codegenpnpm codegen:check:graphql/:oclifbin/check-codegen-clean.jsholds each check's owned paths and fix message. Thegraphql-schemaandoclif-checksjobs now call these scripts instead of inlining steps (−24/+4).Behavior-preserving: same generators, order, and per-area messages. Job names, runners, and the oclif
Buildstep are unchanged, so required checks and the merge queue are unaffected. Not user-facing.How to test your changes?
pnpm codegenproduces no diff (idempotent).pnpm codegen:check:ocliffails withRun pnpm refresh-manifests…and the diff;pnpm codegenrestores clean.Notes
codegen:check: the whole-repogit statusasserts cross-contaminate in one working tree, so CI keeps them as isolated fresh-checkout jobs.pnpm codegenis non-idempotent onmaintoday — it deletes orphanedconfig:autoupgradedocs, which the OCLIF gate doesn't catch (asserts onlygenerated/*.json). Pre-existing; separate fix.Post-release steps
None.