Skip to content

Swap jsdom for happy-dom test env (ui-extensions) #7731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amcaplan wants to merge 1 commit into
base: main
Choose a base branch
from
+331 −509
Draft

Swap jsdom for happy-dom test env (ui-extensions) #7731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swap-jsdom-happy-dom-ui-extensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/ui-extensions-server-kit': patch
---

Replace `jsdom` devDependency with `happy-dom` as the vitest test environment. This is an internal test-tooling change with no impact on the published package surface.
2 changes: 1 addition & 1 deletion packages/ui-extensions-dev-console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@vitejs/plugin-react": "^5.1.4",
"jsdom": "^25.0.0",
"happy-dom": "^20.10.1",
"sass": "^1.83.1",
"vite": "6.4.1"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-extensions-dev-console/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default defineConfig({
},
test: {
globals: true,
environment: 'jsdom',
environment: 'happy-dom',
setupFiles: [path.resolve(__dirname, './tests/setup.ts')],
deps: {
inline: ['@shopify/react-testing'],
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-extensions-server-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@testing-library/react": "^16.3.2",
"@types/react": "^18.2.0",
"@vitejs/plugin-react": "^5.1.4",
"jsdom": "^25.0.0",
"happy-dom": "^20.10.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"vite": "6.4.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/ui-extensions-server-kit/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default defineConfig({
},
test: {
globals: true,
environment: 'jsdom',
environment: 'happy-dom',
setupFiles: [path.resolve(__dirname, './tests/setup.ts')],
deps: {
inline: ['@shopify/react-testing'],
Expand Down
Loading
Loading