Swap jsdom for happy-dom test env (ui-extensions)#7731
Draft
amcaplan wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap
jsdom→happy-domtest environment in ui-extensions packagesWhy: Part of an initiative to cut low-value dependency churn (jsdom: ~2 Dependabot bumps / 24 months).
happy-domis a lighter, faster vitest browser environment with no feature gap for these packages' test suites.What changed (devDep-only — 4 files):
packages/ui-extensions-dev-console/vite.config.mts— vitestenvironment: 'jsdom'→'happy-dom'packages/ui-extensions-server-kit/vite.config.mts— vitestenvironment: 'jsdom'→'happy-dom'package.json— removed"jsdom": "^25.0.0", added"happy-dom": "^20.10.1"to devDependencies@shopify/ui-extensions-server-kit(dev-console is"private": true)Validation: All tests pass under happy-dom with no test-code changes — the swap is transparent.
(server-kit type-check ✅. dev-console has pre-existing ReactNode type errors in
.tsxfiles untouched by this change — a test-environment/devDep swap cannot affect those.)Surface impact: devDependencies only — the published artifact of
@shopify/ui-extensions-server-kitis unaffected.🤖 AI-generated draft — needs human review before merge.