Skip to content

[Tests] Make 'refreshes extension url' test deterministic #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gonzaloriestra merged 1 commit into from
May 5, 2026
Merged

[Tests] Make 'refreshes extension url' test deterministic #7461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions packages/ui-extensions-server-kit/src/state/reducers/extensionServerReducer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
createFocusAction,
createUnfocusAction,
} from '../actions'
import {vi} from 'vitest'

import type {ExtensionServerState} from './types'

Expand Down Expand Up @@ -92,8 +93,11 @@ describe('extensionServerReducer()', () => {
})
})

// eslint-disable-next-line vitest/no-disabled-tests
test.skip('refreshes extension url', async () => {
test('refreshes extension url', () => {
vi.useFakeTimers()
const time1 = 1000
vi.setSystemTime(time1)

const extension = mockExtension()
const previousState: ExtensionServerState = {
store: 'test-store.com',
Expand All @@ -105,20 +109,21 @@ describe('extensionServerReducer()', () => {
const state1 = extensionServerReducer(previousState, action)

const url1 = new URL(state1.extensions[0].assets.main.url)
const timestamp1 = url1.searchParams.get('lastUpdated') ?? ''
const timestamp1 = url1.searchParams.get('lastUpdated')

expect(timestamp1.length).toBeGreaterThan(0)
expect(timestamp1).toBe(time1.toString())

// sleep 1ms to guarantee new timestamp
await new Promise((resolve) => setTimeout(resolve, 1))
const time2 = 2000
vi.setSystemTime(time2)

const state2 = extensionServerReducer(state1, action)

const url2 = new URL(state2.extensions[0].assets.main.url)
const timestamp2 = url2.searchParams.get('lastUpdated') ?? ''
const timestamp2 = url2.searchParams.get('lastUpdated')

expect(timestamp2).toBe(time2.toString())

expect(timestamp2.length).toBeGreaterThan(0)
expect(timestamp1).not.toStrictEqual(timestamp2)
vi.useRealTimers()
})

describe('focus', () => {
Expand Down
Loading