Skip to content

[Tests] Make 'refreshes extension url' test deterministic#7461

Merged
gonzaloriestra merged 1 commit into
mainfrom
fix-deterministic-refresh-test-8839888816816504392
May 5, 2026
Merged

[Tests] Make 'refreshes extension url' test deterministic#7461
gonzaloriestra merged 1 commit into
mainfrom
fix-deterministic-refresh-test-8839888816816504392

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The test refreshes extension url in packages/ui-extensions-server-kit/src/state/reducers/extensionServerReducer.test.ts was skipped and relied on real-time passage (setTimeout) to verify timestamp changes. This is non-deterministic and can lead to flakiness.

WHAT is this pull request doing?

  • Unskips the refreshes extension url test.
  • Refactors the test to use vi.useFakeTimers() and vi.setSystemTime().
  • Replaces loose assertions with exact timestamp checks.
  • Removes the asynchronous setTimeout block, making the test synchronous and faster.

How to test your changes?

Run the unit tests for the affected package:

pnpm --filter @shopify/ui-extensions-server-kit vitest run src/state/reducers/extensionServerReducer.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is NOT user-facing.

PR created automatically by Jules for task 8839888816816504392 started by @gonzaloriestra

Unskip the 'refreshes extension url' test in `extensionServerReducer.test.ts`
and refactor it to use Vitest's fake timers. This removes the dependency
on real time and `setTimeout`, making the test faster and deterministic.
Exact timestamp assertions are also added for better verification.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 5, 2026
@gonzaloriestra gonzaloriestra marked this pull request as ready for review May 5, 2026 07:43
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner May 5, 2026 07:43
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label May 5, 2026 — with Graphite App

gonzaloriestra commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • May 5, 2:33 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 5, 2:33 PM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 9f31416 May 5, 2026
95 of 103 checks passed
@gonzaloriestra gonzaloriestra deleted the fix-deterministic-refresh-test-8839888816816504392 branch May 5, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants