Skip to content

[DNM] Test logs #7336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melissaluu wants to merge 1 commit into from
Closed

[DNM] Test logs #7336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/app/src/cli/services/dev/extension/payload/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ function getAdminConfig(extensions: ExtensionInstance[]): AdminConfig | undefine
const adminExtension = extensions.find((ext) => ext.type === 'admin')
if (!adminExtension) return undefined
const admin = (adminExtension.configuration as AdminConfigType).admin

console.log('..........getAdminConfig........')

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using console.log in CLI code paths. This bypasses the CLI output system (e.g., outputDebug/concurrent output context), makes logs hard to control, and can pollute user output/tests. Please remove this debug log, or if you truly need it, route it through outputDebug from @shopify/cli-kit/node/output at an appropriate call site where you have access to stdout/stderr.

Suggested change
console.log('..........getAdminConfig........')
outputDebug('..........getAdminConfig........')

Copilot uses AI. Check for mistakes.

return {
allowedDomains: admin?.allowed_domains ?? [],
staticRoot: admin?.static_root,
Expand Down
Loading