Skip to content

[DNM] Test logs#7336

Closed
melissaluu wants to merge 1 commit into
mainfrom
20260415-test-main-snapshot
Closed

[DNM] Test logs#7336
melissaluu wants to merge 1 commit into
mainfrom
20260415-test-main-snapshot

Conversation

@melissaluu

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@melissaluu melissaluu requested a review from a team as a code owner April 16, 2026 21:12
Copilot AI review requested due to automatic review settings April 16, 2026 21:12
@melissaluu

Copy link
Copy Markdown
Contributor Author

/snapit

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a debug log statement to the extensions dev payload generation path (admin config extraction) within the app CLI.

Changes:

  • Inserted a console.log call inside getAdminConfig() in the extensions payload store.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

if (!adminExtension) return undefined
const admin = (adminExtension.configuration as AdminConfigType).admin

console.log('..........getAdminConfig........')

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using console.log in CLI code paths. This bypasses the CLI output system (e.g., outputDebug/concurrent output context), makes logs hard to control, and can pollute user output/tests. Please remove this debug log, or if you truly need it, route it through outputDebug from @shopify/cli-kit/node/output at an appropriate call site where you have access to stdout/stderr.

Suggested change
console.log('..........getAdminConfig........')
outputDebug('..........getAdminConfig........')

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @melissaluu! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416211307

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@melissaluu melissaluu closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants