[DNM] Test logs#7336
Conversation
|
/snapit |
There was a problem hiding this comment.
Pull request overview
This PR adds a debug log statement to the extensions dev payload generation path (admin config extraction) within the app CLI.
Changes:
- Inserted a
console.logcall insidegetAdminConfig()in the extensions payload store.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (!adminExtension) return undefined | ||
| const admin = (adminExtension.configuration as AdminConfigType).admin | ||
|
|
||
| console.log('..........getAdminConfig........') |
There was a problem hiding this comment.
Avoid using console.log in CLI code paths. This bypasses the CLI output system (e.g., outputDebug/concurrent output context), makes logs hard to control, and can pollute user output/tests. Please remove this debug log, or if you truly need it, route it through outputDebug from @shopify/cli-kit/node/output at an appropriate call site where you have access to stdout/stderr.
| console.log('..........getAdminConfig........') | |
| outputDebug('..........getAdminConfig........') |
|
🫰✨ Thanks @melissaluu! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416211307Caution After installing, validate the version by running |
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
pnpm changeset add