Migrate channel spec to ChannelModule subclass (first proof of concept)#7294
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a9042c2 to
8c23aab
Compare
7fa3570 to
27ef3ed
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -68,14 +68,6 @@ export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): Pa
* @returns The dependency manager
*/
export declare function getPackageManager(fromDirectory: string): Promise<PackageManager>;
-/**
- * Builds the command and argv needed to execute a local binary using the package manager
- * detected from the provided directory or its ancestors.
- */
-export declare function packageManagerBinaryCommandForDirectory(fromDirectory: string, binary: string, ...binaryArgs: string[]): Promise<{
- command: string;
- args: string[];
-}>;
interface InstallNPMDependenciesRecursivelyOptions {
/**
* The dependency manager to use to install the dependencies.
|
8c23aab to
f51e497
Compare
27ef3ed to
10eac4a
Compare
Phase 3b: First spec migrated to the new ExtensionInstance subclass pattern. - Create ChannelModule extending ExtensionInstance directly with: - copy_files build config - include_assets client steps - contract-based deploy config - Create channelDescriptor as a ModuleDescriptor - Register descriptor in loadModuleRegistry() - Remove channel from legacy spec list - Wire moduleRegistry into loadAppFromContext pipeline Channel extensions are now created via descriptor.createModule() instead of new SpecificationBackedExtension() with a factory-generated spec. 513 model tests pass.
f51e497 to
f496cf4
Compare
10eac4a to
3ff45c1
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
pnpm changeset add