Wire loader to support ModuleRegistry alongside ExtensionSpecification#7293
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
a9042c2 to
8c23aab
Compare
afb85b0 to
616f287
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -68,14 +68,6 @@ export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): Pa
* @returns The dependency manager
*/
export declare function getPackageManager(fromDirectory: string): Promise<PackageManager>;
-/**
- * Builds the command and argv needed to execute a local binary using the package manager
- * detected from the provided directory or its ancestors.
- */
-export declare function packageManagerBinaryCommandForDirectory(fromDirectory: string, binary: string, ...binaryArgs: string[]): Promise<{
- command: string;
- args: string[];
-}>;
interface InstallNPMDependenciesRecursivelyOptions {
/**
* The dependency manager to use to install the dependencies.
|
616f287 to
314e17b
Compare
8c23aab to
f51e497
Compare
Phase 3a: Add dual-path instance creation to the AppLoader. - Add ModuleRegistry field to AppLoader - Update createExtensionInstance to check registry first via descriptor.createModule(), falling back to legacy spec path - Add createModuleFromDescriptor method for the new path - Widen findEntryPath signature to accept both specs and descriptors - Add moduleRegistry to ConfigurationLoaderResult type The registry is currently empty so all instances still use the legacy SpecificationBackedExtension path. Next PR will migrate actual specs.
314e17b to
5f66361
Compare
f51e497 to
f496cf4
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
pnpm changeset add