Skip to content

Fix Swift 6 test target isolation#91

Draft
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/swift6/passkit-protocol-compatfrom
kieran-osgood/swift6/test-compile-cleanup
Draft

Fix Swift 6 test target isolation#91
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood/swift6/passkit-protocol-compatfrom
kieran-osgood/swift6/test-compile-cleanup

Conversation

@kieran-osgood-shopify

Copy link
Copy Markdown
Contributor

What changes are you making?

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kieran-osgood-shopify commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 3d0e770 to b001eee Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 6072481 to a0e4139 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from b001eee to c0dce06 Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from a0e4139 to fb1320d Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from c0dce06 to d7ee28f Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from fb1320d to a58d36b Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 9235da6 to d0215be Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 0e6b530 to ae1e7d9 Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 9ad1ab3 to cfdcc01 Compare June 12, 2026 10:58
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch 2 times, most recently from 33c15e1 to 1dc84eb Compare June 12, 2026 12:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from cfdcc01 to 002c7a7 Compare June 12, 2026 12:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 1dc84eb to aa43014 Compare June 12, 2026 15:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 002c7a7 to 998a6f0 Compare June 12, 2026 15:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from aa43014 to 5a41bda Compare June 15, 2026 08:46
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 8946d41 to 7652a1c Compare June 15, 2026 13:17
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 5a41bda to 38cab1f Compare June 15, 2026 13:17
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 38cab1f to f64080e Compare June 15, 2026 14:39
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 7652a1c to 14758e7 Compare June 15, 2026 14:39
@@ -0,0 +1,21 @@
@testable import ShopifyCheckoutKit

final class LockedTestValue<Value: Sendable>: Sendable {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems unnecessary

static var mockStatusCode: Int = 200
static var capturedRequest: URLRequest?
static var capturedRequestBody: Data?
private struct State {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated in queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant