AC Storefront: GraphQL values Sendable#88
Merged
kieran-osgood-shopify merged 1 commit intoJun 16, 2026
Conversation
This was referenced May 13, 2026
Merged
Contributor
Author
This was referenced May 13, 2026
9eec6dd to
aecdfa8
Compare
aecdfa8 to
a2a8f7d
Compare
08574c6 to
92ab70f
Compare
3dce64e to
3dbd021
Compare
65f806c to
5678177
Compare
3dbd021 to
3afa77a
Compare
5678177 to
679b65c
Compare
3afa77a to
37a6f41
Compare
679b65c to
d8af537
Compare
70f862a to
c1ee065
Compare
11 tasks
3cd64d0 to
6ca3a7c
Compare
|
|
||
| if [[ "$MODE" == "fix" ]]; then | ||
| $SWIFTLINT lint --fix --no-cache $QUIET_FLAG | ||
| (cd "$PROJECT_ROOT" && $SWIFTLINT lint --fix --no-cache $QUIET_FLAG) |
Contributor
Author
There was a problem hiding this comment.
the script appears to have been running from the wrong dir - which means the .swiftlint paths were resolving the wrong paths - I had tons of file changes as a result on generated files
6ca3a7c to
efdbeec
Compare
0fb8d20 to
cc14713
Compare
efdbeec to
71fa876
Compare
cc14713 to
f5f36ff
Compare
71fa876 to
f769683
Compare
accb183 to
9054752
Compare
f769683 to
94c8089
Compare
94c8089 to
d4cc791
Compare
9054752 to
1cb7220
Compare
1cb7220 to
ba1bee5
Compare
592b689 to
e723503
Compare
ba1bee5 to
353dc1e
Compare
e723503 to
aa15323
Compare
aa15323 to
2ae6a1e
Compare
markmur
approved these changes
Jun 16, 2026
Contributor
Author
Merge activity
|
kieran-osgood-shopify
added a commit
that referenced
this pull request
Jun 16, 2026
) ### What changes are you making? This is an optional, but encouraged step towards API consistency and preventing future incompatibility issues, following on from #88. #88 migrated the Customer from ObservableObject to struct, so that internal app wiring was simpler. #274 makes the parent objects of Customer (Configuration -> AcceleratedCheckoutsConfiguration -> Customer) all structs. This helps simplify our library code, as well as reduce the public maintenance contract (including easing the mental overhead of understanding what the library is doing) when we are in a strict concurrency world. > [!WARNING] > > This is a breaking change to the V3 API The breaking change will mean changing two statements:   ### How to test <!-- Please outline the steps to test your changes --> --- ### Before you merge > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`) --- <details> <summary>Releasing a new Swift version?</summary> - [ ] I have bumped the version in `ShopifyCheckoutKit.podspec` - [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift` - [ ] I have updated `platforms/swift/CHANGELOG.md` - [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only) </details> <details> <summary>Releasing a new Android version?</summary> - [ ] I have bumped the `versionName` in `platforms/android/lib/build.gradle` - [ ] I have updated `platforms/android/CHANGELOG.md` - [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md` </details> > [!TIP] > See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Important
When reviewing, consider these changes alongside the ones in #274.
#88 highlighted an issue with ObservableObjects + Swift Concurrency that makes it awkward from a library perspective.
To head off future issues and to encourage consistency in the API, I've added #274 as a recommended but not "essential" step in the Swift 6 migration
This PR makes the Storefront/GraphQL checkout path safe to use from Swift concurrency contexts by tightening Sendable boundaries around the Storefront client, cache, request/response values, and test doubles.
Warning
This intentionally includes a breaking Swift API change:
ShopifyAcceleratedCheckouts.Customeris now aSendablevalue type instead of anObservableObjectclass.Customeris checkout identity data, not independently-owned UI state. Modeling it as an immutable struct matches normal Swift/SwiftUI patterns: app/configuration state owns and publishes values, while async/network code receives safe value snapshots.Consumers should continue to observe the configuration object and assign a new customer value when inputs change:
The sample app was updated to use this pattern in:
This removes the need for an internal
CustomerIdentitywrapper and lets Storefront cart creation acceptCustomer?directly.How to test
Validated locally:
dev swift testdev swift lintdev swift api checkdev swift build samplesBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
platforms/swift/ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.