Skip to content

Remove private buyerChange event from Swift and Kotlin protocol #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markmur merged 3 commits into from
Jun 18, 2026
Merged

Remove private buyerChange event from Swift and Kotlin protocol #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5deb2c1
Remove private buyerChange event from Swift and Kotlin protocol
markmur Jun 18, 2026
64bae98
Merge branch 'main' into remove-buyerchange-swift-kotlin
markmur Jun 18, 2026
0447083
Remove dangling buyerChange references from Swift and Kotlin tests
markmur Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion platforms/android/lib/src/main/java/com/shopify/checkoutkit/CheckoutProtocol.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public object CheckoutProtocol {
public val complete: NotificationDescriptor<Checkout> = checkoutDescriptor("ec.complete")
public val messagesChange: NotificationDescriptor<Checkout> = checkoutDescriptor("ec.messages.change")
public val lineItemsChange: NotificationDescriptor<Checkout> = checkoutDescriptor("ec.line_items.change")
internal val buyerChange: NotificationDescriptor<Checkout> = checkoutDescriptor("ec.buyer.change")
public val totalsChange: NotificationDescriptor<Checkout> = checkoutDescriptor("ec.totals.change")
public val error: NotificationDescriptor<ErrorResponse> = NotificationDescriptor(
method = "ec.error",
Expand Down
6 changes: 0 additions & 6 deletions platforms/android/lib/src/test/java/com/shopify/checkoutkit/CheckoutProtocolTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ class CheckoutProtocolTest {
assertThat(CheckoutProtocol.lineItemsChange.method).isEqualTo("ec.line_items.change")
}

@Test
fun `buyerChange descriptor has correct method`() {
assertThat(CheckoutProtocol.buyerChange.method).isEqualTo("ec.buyer.change")
}

@Test
fun `error descriptor has correct method`() {
assertThat(CheckoutProtocol.error.method).isEqualTo("ec.error")
Expand All @@ -65,7 +60,6 @@ class CheckoutProtocolTest {
@Test
fun `supported protocol methods exclude internal or unsupported methods`() {
assertThat(CheckoutProtocol.supportedProtocolMethods).doesNotContain(
CheckoutProtocol.buyerChange.method,
"ec.payment.credential_request",
"ep.cart.ready",
)
Expand Down
1 change: 0 additions & 1 deletion protocol/languages/swift/Sources/ShopifyCheckoutProtocol/CheckoutProtocol.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ public enum CheckoutProtocol {

package static let readyMethod = "ec.ready"

static let buyerChange = NotificationDescriptor<Checkout>(method: "ec.buyer.change")
public static let complete = NotificationDescriptor<Checkout>(method: "ec.complete")
public static let error = NotificationDescriptor<ErrorResponse>(method: "ec.error")
public static let lineItemsChange = NotificationDescriptor<Checkout>(
Expand Down
5 changes: 0 additions & 5 deletions protocol/languages/swift/Tests/ShopifyCheckoutProtocolTests/DescriptorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ struct DescriptorTests {
#expect(CheckoutProtocol.lineItemsChange.method == "ec.line_items.change")
}

@Test func buyerChangeMethod() {
#expect(CheckoutProtocol.buyerChange.method == "ec.buyer.change")
}

@Test func totalsChangeMethod() {
#expect(CheckoutProtocol.totalsChange.method == "ec.totals.change")
}
Expand All @@ -57,7 +53,6 @@ struct DescriptorTests {
}

@Test func excludesInternalOrUnsupportedMethods() {
#expect(!CheckoutProtocol.supportedProtocolMethods.contains(CheckoutProtocol.buyerChange.method))
#expect(!CheckoutProtocol.supportedProtocolMethods.contains("ec.payment.credential_request"))
#expect(!CheckoutProtocol.supportedProtocolMethods.contains("ep.cart.ready"))
}
Expand Down
Loading