Skip to content

[AMD][AgentX] MINIMAX-M3 FP4 MI355X agentX vLLM#2118

Open
ajith-sirra-amd wants to merge 25 commits into
mainfrom
amd/agentx-minimax-m3-vllm
Open

[AMD][AgentX] MINIMAX-M3 FP4 MI355X agentX vLLM#2118
ajith-sirra-amd wants to merge 25 commits into
mainfrom
amd/agentx-minimax-m3-vllm

Conversation

@ajith-sirra-amd

Copy link
Copy Markdown
Collaborator

Summary

  • Add MiniMax-M3 FP4 single-node agentic benchmark support on MI355X using vLLM
  • New script: benchmarks/single_node/agentic/minimaxm3_fp4_mi355x.sh with three KV offload backends: none , native (vLLM OffloadingConnector), lmcache (LMCache MP server + LMCacheMPConnector)
  • New master config entry minimaxm3-fp4-mi355x-vllm-agentic with TP4 search space across none, native, and lmcache backends
  • Image: vllm/vllm-openai-rocm:nightly-69715823df89b11ee684b84066390cbb9092d5c1
  • Model: amd/MiniMax-M3-MXFP4

Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

2 similar comments
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
@seungrokj seungrokj changed the title [AMD] MINIMAX-M3 FP4 vLLM Agentic Support [AMD] MINIMAX-M3 FP4 MI355X agentX vLLM Jul 8, 2026
@seungrokj seungrokj added the AMD label Jul 8, 2026
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
Comment thread benchmarks/single_node/agentic/minimaxm3_fp4_mi355x.sh
Comment thread benchmarks/single_node/agentic/minimaxm3_fp4_mi355x.sh
Comment thread benchmarks/single_node/agentic/minimaxm3_fp4_mi355x.sh Outdated
Comment thread configs/amd-master.yaml Outdated
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
…& Fixing MODEL_PATH Arg in Serve Command.

Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
…& Fixing MODEL_PATH Arg in Serve Command.

Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Comment thread configs/amd-master.yaml Outdated
seungrokj and others added 2 commits July 9, 2026 10:26
…hmark

Drop lmcache case branch, helper functions, and config entry; keep
native-only offload path. Add OFFLOAD_ARGS fallback, enable prefix
caching and hybrid KV cache manager, bump max-num-seqs to 2x CONC.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

seungrokj and others added 2 commits July 9, 2026 12:35
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: ajith-sirra-amd <ajith.sirra@amd.com>
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@cquil11 cquil11 added the agentx AgentX benchmarks, recipes, and infrastructure label Jul 9, 2026 — with ChatGPT Codex Connector
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

1 similar comment
@github-actions

Copy link
Copy Markdown
Contributor

@seungrokj seungrokj self-requested a review July 10, 2026 12:00

@seungrokj seungrokj left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SemiAnalysisAI SemiAnalysisAI deleted a comment from seungrokj Jul 10, 2026
@cquil11

cquil11 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Needs another run.

@cquil11

cquil11 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

@claude fix the formatting in the yaml on this PR

@Klaud-Cold

Klaud-Cold commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Claude finished @cquil11's task in 1m 23s —— View job


Fixed YAML formatting

  • Inspect YAML changes in this PR
  • Fix formatting issues
  • Validate YAML parses
  • Commit and push

What was wrong: This branch had accidentally added one extra space of indentation to the additional-settings block of the unrelated dsv4-fp4-mi355x-sglang-disagg-agentic-hicache entry (the decode section, configs/amd-master.yaml:3170-3172). That made the entire configs/amd-master.yaml fail to parse (yaml.scanner.ScannerError: mapping values are not allowed here, line 3170), which would have broken every sweep driven by that config file.

Fix: Restored the original 10-space indentation so the block matches main exactly. Pushed as e8ff5ba. Both configs/amd-master.yaml and perf-changelog.yaml now parse cleanly, and the PR diff vs main is back to purely additive (the new minimaxm3-fp4-mi355x-vllm-agentic entry, the new script, and the changelog entry).
· Branch

github-actions Bot and others added 2 commits July 10, 2026 17:35
The extra leading space broke YAML parsing of amd-master.yaml.

Co-authored-by: Cameron Quilici <60715037+cquil11@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

@functionstackx functionstackx left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @ajith-sirra-amd @seungrokj

can u please update recipes.vllm.ai with ur new configs?

vllm recipes doesn't currently support offloading tho the inferact guys said they are open to contributions to support mooncake store, lmcache, vllm native offloading support in vllm recipes

as in sglang cookbook recipes , they also have support for cpu offloading recipes

Image

@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agentx AgentX benchmarks, recipes, and infrastructure AMD full-sweep-enabled

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants