Skip to content

git-flow-next-pre: Add version 0.1.1#2530

Merged
z-Fng merged 6 commits intoScoopInstaller:masterfrom
nagromc:git-flow-next
Nov 2, 2025
Merged

git-flow-next-pre: Add version 0.1.1#2530
z-Fng merged 6 commits intoScoopInstaller:masterfrom
nagromc:git-flow-next

Conversation

@nagromc
Copy link
Contributor

@nagromc nagromc commented Oct 21, 2025

Closes #2529

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Added a Windows installer distribution manifest for version 0.1.1, providing separate 64-bit and 32-bit installers with integrity-checked downloads, a pre-install step, centralized checksum verification, and automatic update mapping to streamline installations and updates.

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Walkthrough

Adds a new Scoop-style manifest bucket/git-flow-next-pre.json for git-flow-next v0.1.1, specifying 64‑bit and 32‑bit Windows downloads, SHA256 checksums, a pre_install script, binary shim, GitHub checkver source, and autoupdate mappings.

Changes

Cohort / File(s) Change Summary
Scoop Package Manifest
bucket/git-flow-next-pre.json
New manifest defining git-flow-next v0.1.1 with architecture-specific download URLs (64-bit and 32-bit), integrity SHA256 hashes, pre_install script, bin shim entry, checkver (GitHub releases), and autoupdate mappings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify download URLs and that releases exist at the specified GitHub URLs.
  • Confirm SHA256 hashes match the release artifacts.
  • Validate pre_install script and bin shim paths for Windows architectures.
  • Check autoupdate patterns map correctly to the release assets.

Poem

🐰
I hopped and fetched a little file,
Wrapped checksums, shims, and installer style,
Two arches set, version pinned,
A tidy manifest, neatly trimmed,
Now git-flow-next hops on Windows with a smile.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "git-flow-next-pre: Add version 0.1.1" directly corresponds to the main change in the changeset, which is the addition of a new manifest file for git-flow-next-pre version 0.1.1. The title follows the conventional format specified in the repository's description template (<manifest-name[@version]>: <general summary>), and the author has confirmed this in the PR description checklist. The title is concise, clear, and clearly communicates the primary change to someone scanning the repository history.
Linked Issues Check ✅ Passed The PR closes linked issue #2529, which requested adding git-flow-next as a pre-release package. The code changes implement the core requirements from that issue: creating a manifest file for git-flow-next-pre (following the naming suggestion in the issue comments), defining version 0.1.1, including the correct package metadata (description, homepage, download links for both 64-bit and 32-bit architectures), checksums, and configuration for both autoupdate and binary installation. All primary coding objectives from the linked issue are satisfied by this manifest addition.
Out of Scope Changes Check ✅ Passed The PR contains only a single file addition: bucket/git-flow-next-pre.json, which is a manifest file directly scoped to the requirements in linked issue #2529. This file defines the git-flow-next-pre package version 0.1.1 with appropriate metadata and configuration. No other changes, unrelated modifications, or scope creep are present in the changeset. The addition remains narrowly focused on fulfilling the package request that was approved in the linked issue.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1fdd52 and 64c59d4.

📒 Files selected for processing (1)
  • bucket/git-flow-next-pre.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/git-flow-next-pre.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

git-flow-next

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@nagromc
Copy link
Contributor Author

nagromc commented Oct 21, 2025

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

git-flow-next

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ac843d and a50ba7d.

📒 Files selected for processing (1)
  • bucket/git-flow-next.json (1 hunks)
🔇 Additional comments (1)
bucket/git-flow-next.json (1)

16-21: Update manifest executable name to match released ZIP contents.

The review comment identifies a real naming inconsistency. The ZIP filename git-flow-next-v0.1.1-windows-amd64.zip includes -next-, but the bin executable git-flow-v0.1.1-windows-amd64.exe (line 18) does not. The manifest specifies what Scoop should extract and map, so the executable name must match the actual file inside the released ZIP.

Verify the actual executable filename inside the v0.1.1 release ZIP and update line 18 accordingly. Based on the ZIP naming pattern, the executable is likely git-flow-next-v0.1.1-windows-amd64.exe (with -next-).

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a50ba7d and 77afe33.

📒 Files selected for processing (1)
  • bucket/git-flow-next.json (1 hunks)
🔇 Additional comments (1)
bucket/git-flow-next.json (1)

16-21: Bin mapping needs architecture-specific entries.

The executable names inside the ZIP files do not include a -next- prefix, so the current 64-bit mapping is correct. However, the manifest defines both 64-bit and 32-bit architectures with different executable names (git-flow-v0.1.1-windows-amd64.exe vs git-flow-v0.1.1-windows-386.exe), but the bin mapping only references the 64-bit executable. On 32-bit Windows installations, Scoop will fail to find the binary.

The bin section needs to be updated to architecture-specific mappings:

- "bin": [
+ "architecture": {
+   "64bit": {
+     "bin": [
        [
            "git-flow-v0.1.1-windows-amd64.exe",
            "git-flow"
        ]
    ]
+ ],
+   "32bit": {
+     "bin": [
+       [
+           "git-flow-v0.1.1-windows-386.exe",
+           "git-flow"
+       ]
+     ]
+   }
+ }

Or verify if both architectures can share a single generic binary name by confirming the actual filename structure.

Likely an incorrect or invalid review comment.

@nagromc
Copy link
Contributor Author

nagromc commented Oct 21, 2025

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@z-Fng
Copy link
Member

z-Fng commented Oct 31, 2025

Perhaps we could rename it as git-flow-next-pre?
When git-flow-next releases a stable version, we can then add git-flow-next to the Main/Extras bucket.

@z-Fng
Copy link
Member

z-Fng commented Nov 2, 2025

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

All changes look good.

Wait for review from human collaborators.

git-flow-next-pre

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z-Fng z-Fng merged commit 4354e80 into ScoopInstaller:master Nov 2, 2025
3 checks passed
@z-Fng z-Fng changed the title git-flow-next: Add version 0.1.1 git-flow-next-pre: Add version 0.1.1 Nov 2, 2025
nagromc added a commit to nagromc/dotfiles that referenced this pull request Nov 3, 2025
@nagromc nagromc deleted the git-flow-next branch December 2, 2025 16:26
@z-Fng
Copy link
Member

z-Fng commented Feb 27, 2026

git-flow-next has been added to the Scoop Main bucket. See: ScoopInstaller/Main#7683

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: git-flow-next Pre-Release

2 participants