git-flow-next-pre: Add version 0.1.1#2530
Conversation
WalkthroughAdds a new Scoop-style manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. git-flow-next
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. git-flow-next
|
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/git-flow-next.json(1 hunks)
🔇 Additional comments (1)
bucket/git-flow-next.json (1)
16-21: Update manifest executable name to match released ZIP contents.The review comment identifies a real naming inconsistency. The ZIP filename
git-flow-next-v0.1.1-windows-amd64.zipincludes-next-, but the bin executablegit-flow-v0.1.1-windows-amd64.exe(line 18) does not. The manifest specifies what Scoop should extract and map, so the executable name must match the actual file inside the released ZIP.Verify the actual executable filename inside the v0.1.1 release ZIP and update line 18 accordingly. Based on the ZIP naming pattern, the executable is likely
git-flow-next-v0.1.1-windows-amd64.exe(with-next-).
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/git-flow-next.json(1 hunks)
🔇 Additional comments (1)
bucket/git-flow-next.json (1)
16-21: Bin mapping needs architecture-specific entries.The executable names inside the ZIP files do not include a
-next-prefix, so the current 64-bit mapping is correct. However, the manifest defines both 64-bit and 32-bit architectures with different executable names (git-flow-v0.1.1-windows-amd64.exevsgit-flow-v0.1.1-windows-386.exe), but the bin mapping only references the 64-bit executable. On 32-bit Windows installations, Scoop will fail to find the binary.The bin section needs to be updated to architecture-specific mappings:
- "bin": [ + "architecture": { + "64bit": { + "bin": [ [ "git-flow-v0.1.1-windows-amd64.exe", "git-flow" ] ] + ], + "32bit": { + "bin": [ + [ + "git-flow-v0.1.1-windows-386.exe", + "git-flow" + ] + ] + } + }Or verify if both architectures can share a single generic binary name by confirming the actual filename structure.
Likely an incorrect or invalid review comment.
f4dd027 to
fd8ae77
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Perhaps we could rename it as |
|
/verify |
|
All changes look good. Wait for review from human collaborators. git-flow-next-pre
|
|
|
Closes #2529
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit