-
Notifications
You must be signed in to change notification settings - Fork 40
Introduce multi-slice NuGraph2 inference and filtering #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rtriozzi
wants to merge
58
commits into
develop
Choose a base branch
from
feature/rtriozzi_cerati_NuGraph2_Filter
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
94abed0
first commit of NuGraphIcarus
cerati d728cdb
use IcarusNuSliceHitsProducer
cerati 6f211ce
add script to start local triton server
cerati dc9e706
fix script name
cerati 81247b4
take a quick nap to avoid starting a lar job before the server is ready
cerati 23d0dfd
fix script names, add version for grid processing
cerati 17f1e7b
no sleep better wait
cerati d9bed1c
add NuGraph to reco fcl, switch to libtorch inference by default
cerati 8deda1b
make nugraph part of the pandora sequence
cerati e87380b
add icarus_postPandora_Gauss
cerati 0aa9cdc
remove spurious character
cerati be34e0b
Merge tag 'v10_04_08' into cerati/feature_nugraph2
cerati cb5276c
restore cluster3D
cerati 4eb87e5
Merge branch 'develop' into cerati/feature_nugraph2
cerati 6f1406d
Merge branch 'develop' into cerati/feature_nugraph2
cerati 70b8af6
add icarus_postPandora_Gauss to 1d fcl as well
cerati 6f1b8b7
address G.P.'s comments
cerati f2c7261
moved NuGraph folder, improved fcl documentation
cerati ac05da7
remove cafmaker_nugraph_test.fcl
cerati 5297b0c
rename Icarus to ICARUS
cerati a6a3c8f
remove fEventInfo
cerati 2f14f07
fix assocSliceHitKeys usage
cerati c3b784b
restore correct behavior for allIDs, add PMT positions, fix SimChanne…
cerati 438a62d
addressing comments
cerati 55e0087
addressing comments
cerati d789fe9
improve documentation
cerati 9e55de9
fix typo in description
cerati 5b87ad2
add comment about plane id redefinition for stitching
cerati 275cd7f
Implemented multiple slices inference for NuGraph.
leonardo-lena 79b0b8d
Cleaned a couple couts and slightly improved documentation.
leonardo-lena d184a9d
introduced module to filter Pandora slices with NuGraph, starting fro…
rtriozzi d3e53b2
used better module naming and added NuGraph-reco-specific CAF fcl
rtriozzi a2ad324
fixed fcl and track/shower creation using NuGraph's output
rtriozzi c327614
added ICARUS-specific NuGraph analyzer
rtriozzi 5e1601e
fixed standard 1D stage1 to include NuGraph pass
rtriozzi d602e53
modified standard NuGraph analyzer to include Pandora information
rtriozzi 6dd62fe
added separate Pandora analyzer for in-depth reco. studies
rtriozzi af4c355
updated NG filtering module to take in multiple slices
rtriozzi e4ccb8f
fixed tpcpmt matching after ng
rtriozzi 06f7155
added output filter and semantic values for filtered hits
rtriozzi 56739c2
changed default filter cut according to data/mc studies
rtriozzi d8f4e1f
added output filter and semantic values for filtered hits
rtriozzi 0bce87b
first implementation of NG within Pandora
rtriozzi f01e3d5
Merge pull request #1 from leonardo-lena/feature-nugraph-multislice
leonardo-lena f2792ae
cleaned NG2 analyzer
rtriozzi 64f99e7
fix fcl labels for NG filter
rtriozzi 618b813
added guard when getting NG filter predictions
rtriozzi cbf7046
added re-created hit-NG assns for later use in CAFs
rtriozzi 3f097dd
fixed input hits for truth-matching in CAFs
rtriozzi 81f9bbf
cleaned up analyzer
rtriozzi 1667bb6
accomodated for CAF making changes after second-pass Pandora
rtriozzi 693fa0c
fixed NG labels in cafmaking fcl
rtriozzi d64259d
fcl cleanup
rtriozzi 09d0765
updated to last changes
rtriozzi 19b0633
comment Pandora-NG2 interface, until Pandora PRs are in
rtriozzi 1be08f3
cleanups
rtriozzi 5e9c0ca
data fcls for Pandora+NuGraph2
rtriozzi c9c24f2
address some of Giuseppe's comments
rtriozzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| #include "services_common_icarus.fcl" | ||
| #include "channelmapping_icarus.fcl" | ||
|
|
||
| #include "correctionservices_icarus.fcl" | ||
|
|
||
| #include "cafmaker_defs.fcl" | ||
|
|
||
| process_name: CAFmaker | ||
|
|
||
| services: | ||
| { | ||
| @table::icarus_wirecalibration_minimum_services | ||
| @table::icarus_random_services # from services_common_icarus.fcl | ||
|
|
||
| SpaceChargeService: @local::icarus_spacecharge | ||
| } | ||
|
|
||
| physics: | ||
| { | ||
|
|
||
| producers: { | ||
| @table::caf_preprocess_data_producers | ||
| } | ||
|
|
||
| runprod: [ @sequence::caf_preprocess_data_sequence, cafmaker] | ||
| trigger_paths: [ runprod ] | ||
| } | ||
|
|
||
| physics.producers.cafmaker.G4Label: "" | ||
| physics.producers.cafmaker.GenLabel: "" | ||
| physics.producers.cafmaker.SimChannelLabel: "" | ||
| physics.producers.cafmaker.SystWeightLabels: [] | ||
| physics.producers.cafmaker.SaveGENIEEventRecord: false | ||
|
|
||
| physics.producers.cafmaker.TriggerLabel: "daqTrigger" # the general configuration, for MC, has a different one (see also https://github.com/SBNSoftware/icaruscode/issues/556) | ||
|
|
||
| ## Grab the second-pass Pandora reconstruction, after NuGraph2's filter | ||
| physics.producers.cafmaker.PFParticleLabel: "pandoraGausNuGraphReco" | ||
|
|
||
| ## Use NuGraph2's PID after NuGraph2's filter | ||
| physics.producers.cafmaker.UsePandoraAfterNuGraph: true | ||
| physics.producers.cafmaker.NuGraphFilterLabel: "ngfilteredhits:filter" | ||
| physics.producers.cafmaker.NuGraphSemanticLabel: "ngfilteredhits:semantic" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #include "cafmakerjob_icarus.fcl" | ||
| #include "cafmaker_add_detsim2d_icarus.fcl" | ||
|
|
||
| ## Always refer to the original hit collection | ||
| physics.producers.cafmaker.HitLabel: "cluster3D" | ||
|
|
||
| ## Grab the second-pass Pandora reconstruction, after NuGraph2's filter | ||
| physics.producers.cafmaker.PFParticleLabel: "pandoraGausNuGraphReco" | ||
|
|
||
| ## Use NuGraph2's PID after NuGraph2's filter | ||
| physics.producers.cafmaker.UsePandoraAfterNuGraph: true | ||
| physics.producers.cafmaker.NuGraphFilterLabel: "ngfilteredhits:filter" | ||
| physics.producers.cafmaker.NuGraphSemanticLabel: "ngfilteredhits:semantic" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I'll clarify this on my own after checking the rest of the code, but I wanted to make sure what some of the labels refer to:
nuslhitsCryoE/W are the hits before nu-graph filtering
NuGraphCryoE/W I guess is a "global object/container" for all nu-graph related reconstruction
NCCSlicesCryoE/W is the "not clear cosmic" single slice considered as the neutrino candidate slice based on the trigger/optical flash
NGMultiSliceCryoE/W corresponds to nu-graph being applied to all non clear cosmic slices in a certain event
ngfilteredhitsCryoE/W corresponds to post-nu-graph-filtering hits
is this interpretation correct?
Perhaps, especially as far as NCCSlicesCryoE/W and NGMultiSliceCryoE/W are concerned at least, I'd add a comment to clarify/specify some details in the fhicl.