Skip to content

Conversation

@rtriozzi
Copy link

@rtriozzi rtriozzi commented Nov 14, 2025

This PR integrates additional NuGraph2 modules in ICARUS, including some that were already introduced in Giuseppe's icaruscode PR #815, on which this PR is based, as well as new modules designed to:

  • run NuGraph2 on multiple slices (e.g., those that are tagged as not-clear-cosmic by Pandora), based on work by summer intern Leonardo Lena;
  • filter hits from Pandora slices based on the NuGraph2 "filter" score.

Along with the modules, a set of FHiCL files is provided. They are all based on the standard v10_06_00_01p01 configurations. Following the review of this PR, similar FHiCL files based on develop will be provided.

More information on NuGraph2 and its applications can be found in SBN DocDB #40585, #44208, Indico.

A companion PR to sbncode is available for dealing with CAF-making after the NG2 filter module (sbncode PR #616).


Associated PRs


Review

Tagging for review @acampani and @PetrilloAtWork as reconstruction and infrastructure experts. Thanks a lot!

@rtriozzi rtriozzi added the enhancement New feature or request label Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this executable and the other one to run on grid are meant to setup tritonserver on the grid/interactively respectibely, but I wanted to understand better what's the scope of both scripts and perhaps I'd recommend adding a short description to both in case people want to use them.

Copy link

@acampani acampani Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I'll clarify this on my own after checking the rest of the code, but I wanted to make sure what some of the labels refer to:
nuslhitsCryoE/W are the hits before nu-graph filtering
NuGraphCryoE/W I guess is a "global object/container" for all nu-graph related reconstruction
NCCSlicesCryoE/W is the "not clear cosmic" single slice considered as the neutrino candidate slice based on the trigger/optical flash
NGMultiSliceCryoE/W corresponds to nu-graph being applied to all non clear cosmic slices in a certain event
ngfilteredhitsCryoE/W corresponds to post-nu-graph-filtering hits
is this interpretation correct?
Perhaps, especially as far as NCCSlicesCryoE/W and NGMultiSliceCryoE/W are concerned at least, I'd add a comment to clarify/specify some details in the fhicl.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify how these two fhicl parameters set to false change the settings in pandora?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants