Add fmt formatter for TypeSafeIndex and deprecate operator<< for LoadYamlOptions and yaml::Node#24075
Conversation
jwnimmer-tri
added
release notes: newly deprecated
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 8 files and all commit messages, and made 2 comments.
Reviewable status: 1 unresolved discussion.
common/type_safe_index.h line 582 at r1 (raw file):
DRAKE_FORMATTER_AS(typename Tag, drake, TypeSafeIndex<Tag>, x, std::to_string(x))
BTW For readability, I think it would be nice to indicate the specific conversion that's happening here.
Suggestion:
std::to_string(int{x})
…`LoadYamlOptions` and `yaml::Node`
j4yyousi
force-pushed
the
pr10-deprecate-LoadYamlOptions-yamlNode-operator<<
branch
from
c296ef8 to
e12a632
Compare
j4yyousi
left a comment
j4yyousi
left a comment
There was a problem hiding this comment.
@j4yyousi resolved 1 discussion.
Reviewable status:complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform).
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
@jwnimmer-tri reviewed 1 file and all commit messages.
Reviewable status:
2 participants
Towards #17742. @jwnimmer-tri, for review please, thanks!
This change is