Skip to content

[tools] Update Debian compat version#24049

Merged
jwnimmer-tri merged 1 commit intoRobotLocomotion:masterfrom
tyler-yankee:deb-compat
Feb 23, 2026
Merged

[tools] Update Debian compat version#24049
jwnimmer-tri merged 1 commit intoRobotLocomotion:masterfrom
tyler-yankee:deb-compat

Conversation

@tyler-yankee
Copy link
Copy Markdown
Contributor

@tyler-yankee tyler-yankee commented Feb 2, 2026

See https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.en.html; v9 is deprecated, v13 is currently recommended.


This change is Reviewable

@tyler-yankee
Copy link
Copy Markdown
Contributor Author

@drake-jenkins-bot linux-noble-unprovisioned-gcc-cmake-experimental-packaging please.

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+a:@mwoehlke-kitware for feature review, please. (I imagine mostly just sanity checking CI results and the linked Debian changelog for any sharp edges?)

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers, missing label for release notes (waiting on @tyler-yankee).

@jwnimmer-tri
Copy link
Copy Markdown
Collaborator

BTW I wouldn't bother with trying to read the changelog. Instead, I would diff the *.deb contents before and after this PR.

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ debdiff drake-dev_0.0.20260202.142715+gite70fb8ec-1_amd64-noble.deb drake-dev_latest-1_amd64-noble.deb
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)
------------------------------------------------
Version: [-0.0.20260202.142715+gite70fb8ec-1-] {+0.0.20260203-1+}

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers.

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @mwoehlke-kitware as a reminder to please review when you have time (low priority), thanks!

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers.

@mwoehlke-kitware
Copy link
Copy Markdown
Contributor

What actually needs to be done here, review-wise? I don't really know anything about .deb packaging, so I can't do much more than rubber-stamp the actual changes. And IIUC "diff the *.deb contents before and after" has been done?

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, wasn't sure if you'd have any input/experience here but wanted a second set of eyes in any case. I'm definitely no expert here either. However, I'd like to stay away from the deprecation warning, and I'm mostly relying on CI being green plus the diff.

@tyler-yankee made 1 comment.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers.

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe we can also just wait to merge this until later this week, after the release.

@tyler-yankee made 2 comments.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers.


a discussion (no related file):
Working

I can test this tomorrow with DEE drake_cmake_installed_apt GHA; IIRC we set that up to be able to run with experimental .deb files.

Copy link
Copy Markdown
Contributor Author

@tyler-yankee tyler-yankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyler-yankee made 1 comment and resolved 1 discussion.
Reviewable status: LGTM missing from assignee mwoehlke-kitware, needs platform reviewer assigned, needs at least two assigned reviewers.


a discussion (no related file):

Previously, tyler-yankee (Tyler Yankee) wrote…

Working

I can test this tomorrow with DEE drake_cmake_installed_apt GHA; IIRC we set that up to be able to run with experimental .deb files.

https://github.com/RobotLocomotion/drake-external-examples/actions/runs/22106598878 is 🟢 using the .tar.gz and .deb from https://drake-jenkins.csail.mit.edu/job/linux-noble-unprovisioned-gcc-cmake-experimental-packaging/job/PR-24049/2/

Copy link
Copy Markdown
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to say :lgtm: just so I'm not blocking, with the disclaimer that all I'm really saying is "updating the compat version seems like a reasonable thing to do, and it looks like this patch does that and doesn't have obvious coding errors".

@mwoehlke-kitware made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.

@jwnimmer-tri jwnimmer-tri self-assigned this Feb 23, 2026
Copy link
Copy Markdown
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jwnimmer-tri reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),mwoehlke-kitware.

@jwnimmer-tri jwnimmer-tri merged commit 911e73a into RobotLocomotion:master Feb 23, 2026
11 checks passed
j4yyousi pushed a commit to j4yyousi/drake that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: low release notes: none This pull request should not be mentioned in the release notes

Development

Successfully merging this pull request may close these issues.

3 participants