Add exclude filter to verify_boot_sources_reimported#4983
Open
rlobillo wants to merge 6 commits into
Open
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThreads an optional exclude_data_source_names collection from HCO helper functions into verify_boot_sources_reimported, skips listed DataSources during verification, tightens unit-test call assertions, and adds a session fixture that disables verification while excluding a custom DataSource. ChangesSelective DataSource verification exclusion
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4983 +/- ##
==========================================
- Coverage 98.67% 98.65% -0.02%
==========================================
Files 25 25
Lines 2487 2456 -31
==========================================
- Hits 2454 2423 -31
Misses 33 33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
Contributor
Author
|
/build-and-push-container |
Contributor
Author
|
/build-and-push-container |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
utilities/storage.py (1)
1-1:⚠️ Potential issue | 🟠 Major | ⚡ Quick winHIGH: PR template required sections are missing/incomplete in the provided PR description.
Please restore the required template headings and provide meaningful content under
##### What this PR does / why we need it:before merge.As per coding guidelines, required PR sections must be present, and
What this PR does / why we need it:must contain meaningful content.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@utilities/storage.py` at line 1, The PR description is missing required template headings and the section "##### What this PR does / why we need it:" is empty; update the PR description to restore all required template headings and populate "##### What this PR does / why we need it:" with a concise summary of the change, its purpose, and any high-level impact (e.g., files/classes affected, behavior changes), ensuring other template sections (e.g., testing steps, related tickets) are present and meaningful before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@utilities/storage.py`:
- Line 1124: The public type for data_source_names in
verify_boot_sources_reimported is too narrow (list[str] | None) while callers
pass a set[str]; change the parameter annotation to accept any collection (e.g.,
Collection[str] | None or Iterable[str] | None) and update the docstring to
reflect it, then update the other affected signatures/usages mentioned (around
the other occurrences) to the same broader type; ensure the function still uses
only membership checks so no logic changes are needed and adjust any related
type imports (typing.Collection or Iterable) accordingly.
---
Outside diff comments:
In `@utilities/storage.py`:
- Line 1: The PR description is missing required template headings and the
section "##### What this PR does / why we need it:" is empty; update the PR
description to restore all required template headings and populate "##### What
this PR does / why we need it:" with a concise summary of the change, its
purpose, and any high-level impact (e.g., files/classes affected, behavior
changes), ensuring other template sections (e.g., testing steps, related
tickets) are present and meaningful before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 68fb094f-6b49-41df-b4d4-504f654a96fa
📒 Files selected for processing (3)
utilities/hco.pyutilities/storage.pyutilities/unittests/test_hco.py
📜 Review details
🧰 Additional context used
📓 Path-based instructions (3)
**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
**/*.py: Never add linter suppressions like# noqa,# type: ignore, or# pylint: disable. Fix the code instead. If you believe a rule is wrong, ask the user for explicit approval.
Search the codebase for existing implementations before writing new code. Checkutilities/,libs/,tests/, andpyproject.tomldependencies. Never duplicate logic—extract to shared modules. Usepyhelper_utils.shell.run_commandfor shell commands instead ofsubprocess.run, and useocp-resourcesclasses instead of raw YAML dicts.
Type hints are MANDATORY. Use mypy strict mode inlibs/and all new public functions under utilities. UseTYPE_CHECKINGfor type-only imports to avoid runtime overhead and circular imports.
Write Google-format docstrings for all public functions with non-obvious return values or side effects.
Always useuv runto execute commands. Never executepython,pip,pytest,tox, orpre-commitdirectly. Useuv run python,uv run pytest,uv run tox,uv run pre-commit, anduv addfor package installation.
Always use absolute imports. Never use relative imports.
Prefer specific imports usingfrom module import funcfor functions and constants. Usefrom package import module(thenmodule.Name) when retaining the module name meaningfully improves readability. Never use bareimport modulewithout afromclause.
Always use named arguments for function calls with more than one argument.
Never use single-letter variable names. Always use descriptive, meaningful names.
No dead code. Every function, variable, and fixture must be used or removed. Code marked with# skip-unused-codeis excluded from dead code analysis (enforced via custom ruff plugin).
Prefer direct attribute access usingfoo.attr. Save to variables only when reusing the same attribute multiple times improves readability or extracting clarifies intent.
Imports must always be at the top of the module. Do not import inside functions.
No defensive programming. Fail...
Files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
**
⚙️ CodeRabbit configuration file
**: ## PR Template Validation
Check the PR description for required sections from.github/pull_request_template.md.
Required sections (must be present, even if empty):
##### What this PR does / why we need it:— MUST be present AND have meaningful content.
Flag as HIGH if the section is missing, empty, whitespace-only, contains only HTML comments,
or contains only placeholder tokens such asTBD,TBA,N/A,-,—,none, or..##### Which issue(s) this PR fixes:— must be present (may be empty)##### Special notes for reviewer:— must be present (may be empty)##### jira-ticket:— must be present (may be empty)
If any required section is absent, orWhat this PR does / why we need it:has no content,
flag it as HIGH severity and ask the author to restore the missing template section(s).
Files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
utilities/storage.py
📄 CodeRabbit inference engine (AGENTS.md)
Place storage operations (PVC, DataVolume, StorageClass) in
utilities/storage.py.
Files:
utilities/storage.py
🧠 Learnings (31)
📚 Learning: 2026-01-12T11:24:13.825Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 3387
File: tests/network/provider_migration/libprovider.py:50-52
Timestamp: 2026-01-12T11:24:13.825Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when catching exceptions in Python, use LOGGER.error before re-raising and do not replace it with LOGGER.exception in except blocks. This follows the established pattern across the codebase.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-01-12T14:25:05.723Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3366
File: tests/storage/cdi_clone/test_clone.py:5-9
Timestamp: 2026-01-12T14:25:05.723Z
Learning: In Python tests and utility code across the repository, bitmath.parse_string_unsafe correctly parses Kubernetes quantities (e.g., '4Gi', '512Mi', PVC storage requests) without supplying system=bitmath.NIST. There are 30+ usages indicating this is the standard behavior. Reviewers should verify that code that builds or compares quantity strings does not pass the NIST parameter, and if a new test relies on quantity parsing, assume no NIST parameter is required unless explicitly documented.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-01-20T01:03:13.139Z
Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 3387
File: tests/network/provider_migration/libprovider.py:1-8
Timestamp: 2026-01-20T01:03:13.139Z
Learning: In the openshift-virtualization-tests repository, Python imports should consistently use module-level imports for the logging module (i.e., import logging) rather than from logging import ... The established pattern spans 270+ files and should not be flagged for refactoring. Apply this guideline to Python files across the repo (e.g., tests/network/provider_migration/libprovider.py).
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-01-21T21:26:41.805Z
Learnt from: geetikakay
Repo: RedHatQE/openshift-virtualization-tests PR: 3559
File: utilities/infra.py:251-254
Timestamp: 2026-01-21T21:26:41.805Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when reviewing Python code, recognize that with Python 3.14 the syntax 'except ValueError, TypeError:' is valid if there is no 'as' clause, and should not be flagged as Python 2 syntax. If you use an 'as' binding (e.g., 'except (ValueError, TypeError) as e:'), parentheses are required. Ensure this pattern is version-consistent and not flagged as Python 2 syntax when 'as' is absent.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-01-25T13:18:21.675Z
Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:21.675Z
Learning: In reviews of the openshift-virtualization-tests repo (and similar Python code), avoid suggesting minor stylistic changes that require extra verification (e.g., removing dict.keys() checks for membership) unless the change has clear correctness or maintainability impact. Focus on fixes with observable behavior, security, performance, or maintainability benefits; defer low-impact style tweaks that are costly to verify.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-02-18T06:35:39.536Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3847
File: utilities/virt.py:2449-2453
Timestamp: 2026-02-18T06:35:39.536Z
Learning: In Python code, a function named clearly and self-descriptively can be deemed not to require a docstring. However, treat this as a context-specific guideline and not a universal rule. For public APIs or functions with side effects, prefer concise docstrings explaining behavior, inputs, outputs, and side effects. This guidance is based on the example in utilities/virt.py from RedHatQE/openshift-virtualization-tests where validate_libvirt_persistent_domain(vm, admin_client) was considered self-documenting.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-02-23T16:33:22.070Z
Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 3883
File: utilities/pytest_utils.py:441-463
Timestamp: 2026-02-23T16:33:22.070Z
Learning: In Python code reviews, the guideline to always use named arguments for multi-argument calls does not apply to built-ins or methods that have positional-only parameters (those defined with a / in their signature). Do not flag or require named arguments for calls like dict.get(key, default=None, /), list.pop(), str.split(sep, maxsplit) and similar built-ins that cannot accept keyword arguments. Apply the named-argument rule only to functions/methods that explicitly accept keyword arguments.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-03-17T01:32:02.617Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:02.617Z
Learning: In RedHatQE/openshift-virtualization-tests, when reviewing Python files, post targeted inline comments on the Files changed tab at the exact location (file and line) of the issue rather than opening a single discussion thread for multiple issues. This should be done for each applicable location to improve traceability and clarity. If multiple issues exist in the same file, address them with separate inline comments pointing to the specific lines.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-03-17T01:32:02.617Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:02.617Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CodeRabbit should post targeted inline comments at each applicable location in the Files Changed tab, rather than aggregating multiple issues into a single PR discussion thread reply. This guideline applies to all Python files (any file ending in .py) changed in a PR; for non-Python files, follow the same inline-comment-at-location principle if relevant.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-04T13:45:29.122Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4725
File: utilities/console.py:54-59
Timestamp: 2026-05-04T13:45:29.122Z
Learning: During review of RedHatQE/openshift-virtualization-tests “lint-cleanup” PRs (e.g., changes targeting lint issues like stale noqa/utf-8 headers), do not flag existing `# type: ignore` directives that were already present before the PR and were not introduced or modified by the PR. Only raise findings for `# type: ignore` suppressions that the PR itself adds, changes, or otherwise makes newly effective (i.e., they appear in the diff as additions/edits).
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-04T13:45:33.892Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4725
File: tests/virt/cluster/common_templates/centos/test_centos_os_support.py:78-83
Timestamp: 2026-05-04T13:45:33.892Z
Learning: When reviewing lint-cleanup or formatting-only pull requests in this repo (e.g., changes like removing/updating `# noqa` comments or UTF-8 headers), do not raise findings for code patterns that already existed before the PR. Specifically, if a problematic construct such as `.is_connective(tcp_timeout=120)` was present in the base branch, suppress that finding and only raise issues when the PR itself introduces or modifies that construct (i.e., the diff adds/changes the call or its arguments). Apply this rule across all Python files (`**/*.py`).
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-05T17:01:15.294Z
Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4739
File: tests/virt/node/descheduler/conftest.py:2-2
Timestamp: 2026-05-05T17:01:15.294Z
Learning: In this repo’s Python code, it’s acceptable (and preferred by convention) to build `run_command` inputs using `shlex.split(f"<command> {arg}")` rather than converting to direct list literals like `['oc', 'adm', 'uncordon', name]`. During code review, generally don’t flag `shlex.split(...)` usage for `run_command` calls and don’t suggest replacing it with list literals; the string-form pattern is used to keep commands readable and consistent with how they’re typed in a terminal.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-08T12:49:20.694Z
Learnt from: geetikakay
Repo: RedHatQE/openshift-virtualization-tests PR: 4788
File: utilities/os_utils.py:257-262
Timestamp: 2026-05-08T12:49:20.694Z
Learning: In RedHatQE/openshift-virtualization-tests, the Ruff flake8-boolean-trap rules FBT001/FBT002 are intentionally not enabled (pyproject.toml does not select the FBT rules; confirmed via `ruff check --show-settings`). Therefore, do not flag boolean positional parameters as FBT001/FBT002 violations in this repository. If Ruff configuration changes and starts selecting FBT rules, this exception should be reconsidered.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-12T05:10:24.601Z
Learnt from: acinko-rh
Repo: RedHatQE/openshift-virtualization-tests PR: 4780
File: tests/storage/utils.py:568-572
Timestamp: 2026-05-12T05:10:24.601Z
Learning: In this repository, Ruff rule UP043 ("unnecessary default type arguments") is enforced. When annotating `collections.abc.Generator` return types, prefer the single-parameter form `Generator[YieldType]` rather than `Generator[YieldType, None, None]`. Explicit `None, None` for the SendType and ReturnType are unnecessary defaults (per PEP 696) and will trigger UP043. Apply this consistently across all Python files.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-13T19:23:09.603Z
Learnt from: Anatw
Repo: RedHatQE/openshift-virtualization-tests PR: 4833
File: tests/network/localnet/migration_stuntime/libstuntime.py:25-25
Timestamp: 2026-05-13T19:23:09.603Z
Learning: In this repository, do not recommend adding `from __future__ import annotations` to fix forward-reference type annotation issues (e.g., Ruff UP037). Follow the established convention: use quoted string type annotations for forward references when the referenced class/type is defined later in the same file (e.g., `"ContinuousPing"`), and prefer `typing.Self` for self-referential return types.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-18T06:30:56.781Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_bitwarden.py:207-207
Timestamp: 2026-05-18T06:30:56.781Z
Learning: During Ruff/lint rule-enablement PRs in this repository (e.g., when introducing a new rule like PLC0415), it’s acceptable to keep CI green by adding per-line, targeted suppressions for pre-existing violations: add only `# noqa: <single-ruff-rule-id>` at the end of the specific violating line. In this PR context, reviewers should NOT flag these targeted `# noqa: PLC0415` comments as policy violations, assuming the suppression is for a pre-existing issue and is documented in the PR description as a candidate for follow-up cleanup. Do not allow blanket `# noqa` (without a specific rule) or `per-file-ignores`; those remain disallowed.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-18T06:31:12.015Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_pytest_utils.py:270-270
Timestamp: 2026-05-18T06:31:12.015Z
Learning: In RedHatQE/openshift-virtualization-tests, if a PR is a Ruff rule-enforcement PR and its “Special notes for reviewer” documents that pre-existing Ruff violations are being temporarily handled via per-line suppressions (e.g., `# noqa: PLC0415`) to keep CI green, reviewers should treat those specific `# noqa: <rule>` comments as an agreed, temporary mechanism. Do not flag them as code-quality issues and do not recommend removing, consolidating, or refactoring those suppressions within the same PR; cleanup/remediation is expected to happen in dedicated follow-up PRs instead.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-18T06:31:15.083Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_data_collector.py:304-304
Timestamp: 2026-05-18T06:31:15.083Z
Learning: When reviewing Python code in this repository for Ruff/linter rule rollouts, do not treat temporary suppression comments as violations in the specific migration scenario where a PR enables a new Ruff rule (e.g., PLC0415) and the PR description explicitly documents that all *pre-existing* violations are being annotated with `# noqa: <RULE>` as a short-lived measure. In that case, only flag `# noqa: <RULE>` suppressions that are newly introduced on code that did not previously violate the rule—i.e., verify via the PR diff against the prior state (and/or prior Ruff findings) that the suppressed line was already violating before the rule was enabled. Ignore suppressions that are covering violations that existed before the new rule rollout and were intentionally bulk-added for cleanup in follow-up PRs.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-18T06:31:20.848Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_hco.py:501-501
Timestamp: 2026-05-18T06:31:20.848Z
Learning: When reviewing Python code in RedHatQE/openshift-virtualization-tests, avoid flagging Ruff `# noqa: <RULE>` suppressions as issues if they were intentionally added as a temporary measure to keep CI green after a PR enables a new Ruff/lint rule (e.g., PLC0415) and the PR description documents this under "Special notes for reviewer". Treat these suppressions as deferred technical debt. Only flag `# noqa: PLC0415` (and similar rule-specific suppressions) when they are newly introduced without an accompanying documented intent in the PR (and thus appear to be masking a new violation rather than a pre-existing one).
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-18T09:09:09.479Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4878
File: utilities/unittests/test_pytest_utils.py:2194-2197
Timestamp: 2026-05-18T09:09:09.479Z
Learning: In this repository (RedHatQE/openshift-virtualization-tests), do not flag missing return type annotations or missing argument type annotations as Ruff “ANN” rule violations (e.g., ANN001/ANN002/ANN201/ANN202). The repo’s Ruff configuration does not enable ANN rules and only uses `extend-select = ["PLC0415"]`, so missing type annotations should not be treated as ANN lint failures during code review.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-19T07:48:17.119Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4784
File: libs/vm/affinity.py:104-104
Timestamp: 2026-05-19T07:48:17.119Z
Learning: When using Kubernetes API models like `NodeSelectorRequirement` or `LabelSelectorRequirement` with operators `Exists` or `DoesNotExist`, the `values` field must not be non-empty. It is valid for `values` to be omitted / left as `None` (Python) / passed as `null`—Kubernetes rejects non-empty `values` for these operators, but does not require the field to be present or explicitly set to an empty list. In code reviews, do not treat missing `values=[]` for `Exists`/`DoesNotExist` as a validation issue; only flag cases where `values` is provided with actual elements.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-19T07:48:17.119Z
Learnt from: azhivovk
Repo: RedHatQE/openshift-virtualization-tests PR: 4784
File: libs/vm/affinity.py:104-104
Timestamp: 2026-05-19T07:48:17.119Z
Learning: When constructing Kubernetes `NodeSelectorRequirement` (or `LabelSelectorRequirement`) objects in code, do not treat `values` being omitted, `None`, or an empty list as an API-validation problem when the requirement’s operator is `Exists` or `DoesNotExist`. Per the Kubernetes API spec, these operators only require that the `values` array is not non-empty (i.e., it must be empty); they do not require the field to be explicitly present as `[]`. Therefore, reviewers should not flag `values=None`/missing `values` for `Exists`/`DoesNotExist`.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-02-18T06:34:38.042Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3847
File: tests/virt/cluster/common_templates/utils.py:58-58
Timestamp: 2026-02-18T06:34:38.042Z
Learning: In RedHatQE/openshift-virtualization-tests, treat 'public' functions as those defined in any Python files under libs/ or utilities/ (any depth). Functions inside nested test directories (e.g., tests/virt/cluster/common_templates/, tests/virt/node/, etc.) are test helpers and do not require Google-format docstrings unless explicitly requested. Use this rule during reviews to decide whether to enforce docstrings on public API functions in libs/utilities.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-03T15:38:09.624Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4701
File: tests/virt/node/general/test_windows_vtpm_bitlocker.py:50-52
Timestamp: 2026-05-03T15:38:09.624Z
Learning: During review of PRs that are lint cleanups or tooling/version bumps, do not flag code-quality issues for patterns that pre-existed before the PR. Specifically, if the diff does not introduce/modify constructs such as nested `if` blocks or unnecessary list comprehensions, treat them as known/deferred and leave them for dedicated follow-up cleanup PRs. Only raise issues when the PR itself adds, changes, or refactors the problematic code.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-05-15T18:42:02.504Z
Learnt from: geetikakay
Repo: RedHatQE/openshift-virtualization-tests PR: 4860
File: utilities/hco.py:385-389
Timestamp: 2026-05-15T18:42:02.504Z
Learning: In this repository, under the Python `utilities/` directory (utility/helper modules, not tests), do not flag bare `assert` statements as correctness or style issues. The codebase conventionally uses `assert` in these utilities (e.g., `utilities/virt.py`, `utilities/infra.py`, etc.) and does not enforce running Python with `-O`/`PYTHONOPTIMIZE`, so the usual “asserts may be stripped” concern should not be treated as a review blocker here.
Applied to files:
utilities/hco.pyutilities/unittests/test_hco.pyutilities/storage.py
📚 Learning: 2026-01-07T11:51:57.253Z
Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 3301
File: utilities/unittests/test_oadp.py:5-5
Timestamp: 2026-01-07T11:51:57.253Z
Learning: In utilities/unittests/test_oadp.py and similar test files in this repo, include a # flake8: noqa: E402 directive to suppress E402 warnings caused by pre-commit checks. This is needed because mock setup must precede imports to avoid circular dependencies, and Ruff may report unused imports. Apply this directive to all similar test files that require imports to guard against circular import issues.
Applied to files:
utilities/unittests/test_hco.py
📚 Learning: 2026-01-19T07:53:55.780Z
Learnt from: qwang1
Repo: RedHatQE/openshift-virtualization-tests PR: 3301
File: utilities/unittests/test_oadp.py:48-57
Timestamp: 2026-01-19T07:53:55.780Z
Learning: Enforce that pytest markers (e.g., marker requirement for integration tests) apply only to integration/functional tests under the tests/ directory. Unit tests located in utilities/unittests/ must not use pytest markers, following repository convention. For all unit test files under utilities/unittests (and subdirectories), do not require or mandate markers; for integration tests under tests/ and its subdirectories, ensure markers are used as per the project rule.
Applied to files:
utilities/unittests/test_hco.py
📚 Learning: 2026-02-23T21:16:51.920Z
Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 3883
File: utilities/unittests/test_os_utils.py:358-371
Timestamp: 2026-02-23T21:16:51.920Z
Learning: In the openshift-virtualization-tests repository, the guideline to require named arguments for function calls with more than one argument does not apply to unit tests under utilities/unittests/. For these tests, allow standard pytest patterns like pytest.raises(ExceptionType, match="pattern") without requiring named parameters. This exception applies specifically to files under utilities/unittests/ and does not generalize beyond that directory.
Applied to files:
utilities/unittests/test_hco.py
📚 Learning: 2026-05-03T15:38:22.954Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4701
File: utilities/unittests/test_database.py:12-12
Timestamp: 2026-05-03T15:38:22.954Z
Learning: In RedHatQE/openshift-virtualization-tests unit tests under `utilities/unittests/`, it’s intentional/pre-existing to use `sys.path.insert(0, ...)` in cases where tests need to import local modules. In lint-cleanup PRs, reviewers should not flag this `sys.path` manipulation as a violation. Also, don’t re-add `# noqa: E402` or other import-order suppressions if `ruff/flake8` no longer reports E402 for that import—handle any broader refactor (to remove the `sys.path` hack) in a dedicated follow-up.
Applied to files:
utilities/unittests/test_hco.py
📚 Learning: 2026-05-18T06:31:30.830Z
Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 4819
File: utilities/unittests/test_sanity.py:22-22
Timestamp: 2026-05-18T06:31:30.830Z
Learning: In this repo’s unit test files under `utilities/unittests/`, treat `# noqa: PLC0415` (import-outside-top-level) suppressions as intentional and do not flag them as violations when enabling Ruff’s PLC0415 rule incrementally. These suppressions are expected as temporary measures and are documented in the PR description; they should only be targeted for later cleanup follow-ups.
Also, allow imports placed inside unit test methods under `utilities/unittests/` when they are intentionally positioned to run after `patch` decorators are applied—especially when the imported module has import-time side effects.
Applied to files:
utilities/unittests/test_hco.py
📚 Learning: 2026-05-18T10:38:33.820Z
Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 4884
File: .coderabbit.yaml:79-80
Timestamp: 2026-05-18T10:38:33.820Z
Learning: In this repo, pytest tests are expected to live only in files named `test_*.py`. When applying CodeRabbit STP case B (newly added `def test_*` inside an existing test file), scope the check to existing files that match `test_*.py` and do not broaden it to newly added `def test_*` found in other non-`test_*.py` Python files.
Applied to files:
utilities/unittests/test_hco.py
🧬 Code graph analysis (1)
utilities/unittests/test_hco.py (1)
tests/conftest.py (2)
admin_client(310-314)namespace(680-693)
🪛 Ruff (0.15.13)
utilities/storage.py
[warning] 1145-1145: Logging statement uses f-string
(G004)
🔇 Additional comments (2)
utilities/hco.py (1)
389-390: LGTM!utilities/unittests/test_hco.py (1)
769-773: LGTM!Also applies to: 804-807, 839-839
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4983 published |
1 similar comment
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4983 published |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. |
Allow callers to limit DataSource verification to a specific set, skipping custom DataSources without imagestreams. Ref: RedHatQE#4968 Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
The caller passes a set, so the type hint should accept any collection that supports membership checks. Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
…ylist Addresses review feedback: the allowlist approach using data_import_cron_matrix does not cover multiarch DataSource names (e.g. fedora-aarch64) and silently skips valid custom templates. The denylist keeps "verify all" as the default and lets callers exclude specific DataSources when needed. Propagates exclude_data_source_names through disable_common_boot_image_import_hco_spec so test_add_custom_data_import_cron_template_disable_spec can exclude the custom DataSource during teardown verification. Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The teardown AssertionError in verify_boot_sources_reimported (CNV-88015) is fixed by the exclude_data_source_names denylist propagated through disable_common_boot_image_import_hco_spec. Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@tests/install_upgrade_operators/hco_enablement_golden_image_updates/test_update_hco_cr.py`:
- Around line 90-99: The test function
test_add_custom_data_import_cron_template_disable_spec currently lists the
setup-only fixture disabled_boot_image_import_excluding_custom_datasource in its
parameter list which triggers ARG002; remove that fixture from the function
signature and instead declare it via
`@pytest.mark.usefixtures`("disabled_boot_image_import_excluding_custom_datasource")
above the test (keeping existing decorators like `@pytest.mark.dependency` and
`@pytest.mark.polarion`), so the fixture's side effects run without implying the
test consumes a return value.
In `@utilities/unittests/test_hco.py`:
- Around line 769-774: Add a test that exercises the non-default propagation
path by passing a real collection name (e.g., ["my-collection"]) into
disable_common_boot_image_import_hco_spec() and into
enable_common_boot_image_import_spec_wait_for_data_import_cron(), then assert
that verify_boot_sources_reimported() was called with that same collection value
instead of None; update the analogous case around the other assertion block
(lines 832-836) to include a similar non-default propagation check so the test
suite verifies the actual collection argument flows through the call chain
(functions: disable_common_boot_image_import_hco_spec,
enable_common_boot_image_import_spec_wait_for_data_import_cron,
verify_boot_sources_reimported).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0020e5ac-fc1f-4130-8708-29b498c35ce4
📒 Files selected for processing (5)
tests/install_upgrade_operators/hco_enablement_golden_image_updates/conftest.pytests/install_upgrade_operators/hco_enablement_golden_image_updates/test_update_hco_cr.pyutilities/hco.pyutilities/storage.pyutilities/unittests/test_hco.py
Move disabled_boot_image_import_excluding_custom_datasource to @pytest.mark.usefixtures since its return value is not used by the test. Add unit tests verifying exclude_data_source_names propagation with non-default values through both disable_common_boot_image_import_hco_spec and enable_common_boot_image_import_spec_wait_for_data_import_cron. Signed-off-by: Ramón Lobillo <rlobillo@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
/build-and-push-container |
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4983 published |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
Contributor
Author
|
/verified cancel |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
echo "=== HEAD commit SHA ==="
gh pr view $PR_NUMBER --repo $REPO --json headRefOid --jq '.headRefOid'
echo ""
echo "=== First changed file and first +/- line ==="
gh api repos/${REPO}/pulls/${PR_NUMBER}/files --jq '.[0] | {filename: .filename, patch: .patch}' | head -60
echo ""
echo "=== Modified symbols in utilities/ ==="
git diff origin/main...HEAD --unified=0 -- utilities/hco.py utilities/storage.py 2>/dev/null | grep '^[+-]def ' | sort -u
echo ""
echo "=== Direct callers in tests/ ==="
rg -l "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/ --type py 2>/dev/null
echo ""
echo "=== Gating-marked files ==="
rg -l "`@pytest.mark.gating`" tests/ --type py 2>/dev/null
echo ""
echo "=== Smoke-marked files ==="
rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null | head -20
echo ""
echo "=== Check if any gating-marked file imports/calls changed symbols ==="
gating_files=$(rg -l "`@pytest.mark.gating`" tests/ --type py 2>/dev/null)
for f in $gating_files; do
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$f" 2>/dev/null; then
echo "GATING MATCH: $f"
fi
done
echo ""
echo "=== Check conftest.py hierarchy for smoke test files re: changed symbols ==="
smoke_files=$(rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null)
for sf in $smoke_files; do
dir="$sf"
while [ "$dir" != "." ]; do
dir=$(dirname "$dir")
cf="$dir/conftest.py"
if [ -f "$cf" ]; then
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$cf" 2>/dev/null; then
echo "SMOKE CONFTEST MATCH: $sf via $cf"
fi
fi
done
done
echo ""
echo "=== Transitive: same-file callers of changed symbols in utilities/hco.py ==="
rg -n "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" utilities/hco.py utilities/storage.py 2>/dev/null
echo ""
echo "=== fixtures that call enable_common_boot_image_import_spec_wait_for_data_import_cron in conftest files ==="
rg -rn "enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/ --type py -C1 2>/dev/null | head -60Length of output: 11399 🏁 Script executed: #!/bin/bash
COMMIT_SHA="08168799dfd6626cffdad038bfab381f99aae4f5"
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
PATH_FILE="tests/install_upgrade_operators/hco_enablement_golden_image_updates/conftest.py"
LINE=6
COMMENT_BODY="**Test Execution Plan**
- **Run smoke tests: False** — \`tests/conftest.py\` calls \`disable_common_boot_image_import_hco_spec\` / \`enable_common_boot_image_import_spec_wait_for_data_import_cron\` (in smoke tests' conftest hierarchy), but all added parameters use \`None\` defaults, preserving existing call-site behavior. No concrete behavioral change reaches smoke tests.
- **Run gating tests: False** — No gating-marked file appears among the direct callers of the changed symbols.
**Affected tests to run:**
- \`utilities/unittests/test_hco.py\` — unit tests for \`disable_common_boot_image_import_hco_spec\` / \`enable_common_boot_image_import_spec_wait_for_data_import_cron\` / \`verify_boot_sources_reimported\` propagation
- \`tests/install_upgrade_operators/hco_enablement_golden_image_updates/test_update_hco_cr.py::test_add_custom_data_import_cron_template_disable_spec\` — de-quarantined test using new \`disabled_boot_image_import_excluding_custom_datasource\` fixture
- \`tests/infrastructure/golden_images/update_boot_source/conftest.py\` callers — fixtures in this conftest call \`disable_common_boot_image_import_hco_spec\` / \`enable_common_boot_image_import_spec_wait_for_data_import_cron\`
- \`tests/storage/golden_image/test_cached_snapshots.py\` — directly imports a changed symbol from \`utilities.hco\`"
gh api \
repos/${REPO}/pulls/${PR_NUMBER}/comments \
--method POST \
-f body="$COMMENT_BODY" \
-f commit_id="$COMMIT_SHA" \
-f path="$PATH_FILE" \
-F line=$LINE \
-f side="RIGHT" \
--jq '.id'Length of output: 1838 🧠 Learnings used |
Contributor
|
/retest all Auto-triggered: Files in this PR were modified by merged PR #4985. Overlapping filesutilities/storage.py |
Contributor
Author
|
/verified |
|
/build-and-push-container |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
echo "=== HEAD commit SHA ==="
gh pr view $PR_NUMBER --repo $REPO --json headRefOid --jq '.headRefOid'
echo ""
echo "=== First changed file and patch ==="
gh api repos/${REPO}/pulls/${PR_NUMBER}/files --jq '.[0] | {filename: .filename, patch: .patch}' | head -60
echo ""
echo "=== All changed files ==="
gh api repos/${REPO}/pulls/${PR_NUMBER}/files --jq '.[].filename'
echo ""
echo "=== Modified symbols in utilities/ (from PR diff vs main) ==="
git diff origin/main...HEAD --unified=0 -- utilities/hco.py utilities/storage.py 2>/dev/null | grep '^[+-]def ' | sort -u
echo ""
echo "=== Direct callers of changed symbols in tests/ ==="
rg -l "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/ --type py 2>/dev/null
echo ""
echo "=== Same-file callers in utilities/ ==="
rg -n "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" utilities/hco.py utilities/storage.py 2>/dev/null
echo ""
echo "=== Smoke-marked files ==="
rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null
echo ""
echo "=== Gating-marked files ==="
rg -l "`@pytest.mark.gating`" tests/ --type py 2>/dev/null | head -30
echo ""
echo "=== Check if any gating-marked file imports or calls changed symbols ==="
for f in $(rg -l "`@pytest.mark.gating`" tests/ --type py 2>/dev/null); do
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$f" 2>/dev/null; then
echo "GATING MATCH: $f"
fi
done
echo ""
echo "=== Check conftest hierarchy of smoke tests for changed symbols ==="
for sf in $(rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null); do
dir=$(dirname "$sf")
while [ "$dir" != "." ] && [ "$dir" != "" ]; do
cf="$dir/conftest.py"
if [ -f "$cf" ]; then
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$cf" 2>/dev/null; then
echo "SMOKE CONFTEST MATCH: $sf via $cf"
fi
fi
dir=$(dirname "$dir")
done
done
echo ""
echo "=== Transitive callers: find functions in utilities/hco.py that call changed symbols ==="
rg -n "verify_boot_sources_reimported" utilities/hco.py utilities/storage.py 2>/dev/null -C2
echo ""
echo "=== fixtures in conftest that call changed symbols ==="
rg -rn "enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/ --type py -B2 -A2 2>/dev/null | head -80Length of output: 13365 🏁 Script executed: #!/bin/bash
COMMIT_SHA="08168799dfd6626cffdad038bfab381f99aae4f5"
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
PATH_FILE="tests/install_upgrade_operators/hco_enablement_golden_image_updates/conftest.py"
LINE=6
COMMENT_BODY="**Test Execution Plan**
- **Run smoke tests: False** — \`tests/conftest.py\` contains fixtures calling \`disable_common_boot_image_import_hco_spec\`, which is in the conftest hierarchy of all smoke tests. However, all existing call sites pass no \`exclude_data_source_names\` argument, so they use the unchanged \`None\` default — behavior is identical to pre-PR. No behavioral change propagates to smoke tests.
- **Run gating tests: False** — No gating-marked test file calls any of the modified symbols (\`verify_boot_sources_reimported\`, \`enable_common_boot_image_import_spec_wait_for_data_import_cron\`, \`disable_common_boot_image_import_hco_spec\`).
**Affected tests to run:**
- \`utilities/unittests/test_hco.py\` — unit tests verifying \`exclude_data_source_names\` propagation through \`disable_common_boot_image_import_hco_spec\` and \`enable_common_boot_image_import_spec_wait_for_data_import_cron\`
- \`tests/install_upgrade_operators/hco_enablement_golden_image_updates/test_update_hco_cr.py::test_add_custom_data_import_cron_template_disable_spec\` — de-quarantined test; now uses new \`disabled_boot_image_import_excluding_custom_datasource\` fixture with \`exclude_data_source_names={CUSTOM_DATASOURCE_NAME}\`
- \`tests/infrastructure/golden_images/update_boot_source/\` — conftest fixtures call \`enable_common_boot_image_import_spec_wait_for_data_import_cron\` (teardown path); verify teardown still passes after rebase
- \`tests/storage/golden_image/test_cached_snapshots.py\` — imports \`disable_common_boot_image_import_hco_spec\` from \`utilities.hco\`"
gh api \
repos/${REPO}/pulls/${PR_NUMBER}/comments \
--method POST \
-f body="$COMMENT_BODY" \
-f commit_id="$COMMIT_SHA" \
-f path="$PATH_FILE" \
-F line=$LINE \
-f side="RIGHT" \
--jq '.id'Length of output: 2139 🧠 Learnings used |
|
Verification failed for PR #4983. |
Contributor
|
New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4983 published |
Contributor
Author
|
/verified cancel |
Contributor
Author
|
/verified |
Contributor
Test execution plan request detailsCRITICAL: You MUST post an inline review comment on the first changed line of the first file. As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan. Analysis Requirements:
Output rules: Your deliverable: Test Execution Plan
Guidelines:
Hardware-Related Checks (SR-IOV, GPU, DPDK): When PR modifies fixtures for hardware-specific resources:
CRITICAL WORKFLOW COMPLETION RULES: When responding to this test execution plan request, you MUST follow these rules EXACTLY:
ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):
Remember: The pull request review is visible to users. Additional comments are redundant noise. CRITICAL — Verification rules for smoke and gating decisions: |
Contributor
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
echo "=== HEAD commit SHA ==="
gh pr view $PR_NUMBER --repo $REPO --json headRefOid --jq '.headRefOid'
echo ""
echo "=== All changed files with patches ==="
gh api repos/${REPO}/pulls/${PR_NUMBER}/files --jq '.[] | {filename: .filename, patch: (.patch | split("\n") | .[0:5] | join("\n"))}'
echo ""
echo "=== Direct callers of changed symbols ==="
rg -l "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/ --type py 2>/dev/null
echo ""
echo "=== Smoke-marked files ==="
rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null | head -20
echo ""
echo "=== Gating-marked files that call changed symbols ==="
for f in $(rg -l "`@pytest.mark.gating`" tests/ --type py 2>/dev/null); do
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$f" 2>/dev/null; then
echo "GATING MATCH: $f"
fi
done
echo ""
echo "=== Check conftest hierarchy of smoke tests for changed symbols ==="
for sf in $(rg -l "`@pytest.mark.smoke`" tests/ --type py 2>/dev/null); do
dir=$(dirname "$sf")
while [ "$dir" != "." ] && [ "$dir" != "" ]; do
cf="$dir/conftest.py"
if [ -f "$cf" ]; then
if rg -q "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" "$cf" 2>/dev/null; then
echo "SMOKE CONFTEST MATCH: $sf via $cf"
fi
fi
dir=$(dirname "$dir")
done
done
echo "=== conftest hierarchy check done ==="Length of output: 4446 🏁 Script executed: #!/bin/bash
echo "=== tests/conftest.py usage of changed symbols ==="
rg -n "verify_boot_sources_reimported|enable_common_boot_image_import_spec_wait_for_data_import_cron|disable_common_boot_image_import_hco_spec" tests/conftest.py -B5 -A5
echo ""
echo "=== Is fixture autouse? ==="
rg -n "autouse" tests/conftest.py -B3 -A3 | grep -A10 "disable_common_boot_image_import\|verify_boot_sources\|enable_common_boot_image"Length of output: 3624 🏁 Script executed: #!/bin/bash
COMMIT_SHA="08168799dfd6626cffdad038bfab381f99aae4f5"
REPO="RedHatQE/openshift-virtualization-tests"
PR_NUMBER=4983
PATH_FILE="tests/install_upgrade_operators/hco_enablement_golden_image_updates/conftest.py"
LINE=6
COMMENT_BODY="**Test Execution Plan**
- **Run smoke tests: False** — \`tests/conftest.py\` imports \`verify_boot_sources_reimported\` and \`disable_common_boot_image_import_hco_spec\`, but they are used only in non-autouse named fixtures (\`disabled_common_boot_image_import_hco_spec_scope_function\`, \`disabled_common_boot_image_import_hco_spec_scope_class\`, \`removed_default_storage_classes\`). Smoke tests do not request these fixtures. All existing call sites omit \`exclude_data_source_names\`, preserving \`None\` default — no behavioral change.
- **Run gating tests: False** — No gating-marked test file calls any of the modified symbols.
**Affected tests to run:**
- \`utilities/unittests/test_hco.py\` — unit tests verifying \`exclude_data_source_names\` propagation through \`disable_common_boot_image_import_hco_spec\` and \`enable_common_boot_image_import_spec_wait_for_data_import_cron\`
- \`tests/install_upgrade_operators/hco_enablement_golden_image_updates/test_update_hco_cr.py::test_add_custom_data_import_cron_template_disable_spec\` — de-quarantined test using new \`disabled_boot_image_import_excluding_custom_datasource\` fixture with \`exclude_data_source_names={CUSTOM_DATASOURCE_NAME}\`
- \`tests/infrastructure/golden_images/update_boot_source/\` — conftest fixtures call \`enable_common_boot_image_import_spec_wait_for_data_import_cron\` (teardown path); verify teardown passes after rebase
- \`tests/storage/golden_image/test_cached_snapshots.py\` — directly imports \`disable_common_boot_image_import_hco_spec\` from \`utilities.hco\`"
gh api \
repos/${REPO}/pulls/${PR_NUMBER}/comments \
--method POST \
-f body="$COMMENT_BODY" \
-f commit_id="$COMMIT_SHA" \
-f path="$PATH_FILE" \
-F line=$LINE \
-f side="RIGHT" \
--jq '.id'Length of output: 2063 🧠 Learnings used |
Contributor
Author
|
Verified in openshift-virtualization-tests-runner/5553 against CNV 4.22.0 (candidate channel). Test Execution Plan results:
5 ERRORs reported — all unrelated to this PR:
|
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After enabling common boot image imports,
verify_boot_sources_reimportedchecks all DIC-managed DataSources. If the cluster has custom DataImportCron templates whose DataSources lack valid sources, the verification fails waiting for DataSources that will never become Ready.This PR adds an optional
exclude_data_source_namesdenylist parameter so callers can skip specific DataSources. The default remains "verify all", which is backward compatible and automatically covers multiarch DataSource names (e.g.fedora-aarch64) and valid custom templates without requiring an explicit allowlist.The parameter is propagated through
disable_common_boot_image_import_hco_specso thattest_add_custom_data_import_cron_template_disable_speccan exclude the custom DataSource during teardown verification.This PR also de-quarantines
test_add_custom_data_import_cron_template_disable_spec, which was quarantined due to the teardownAssertionErrorinverify_boot_sources_reimported(CNV-88015). The fix resolves the root cause, so the quarantine marker is removed.Which issue(s) this PR fixes:
Special notes for reviewer:
jira-ticket:
CNV-88015
Summary by CodeRabbit
New Features
Tests