Skip to content

Make verify_boot_sources_reimported flexible to select DataSources#4968

Closed
geetikakay wants to merge 1 commit into
RedHatQE:mainfrom
geetikakay:wa_custom_ds
Closed

Make verify_boot_sources_reimported flexible to select DataSources#4968
geetikakay wants to merge 1 commit into
RedHatQE:mainfrom
geetikakay:wa_custom_ds

Conversation

@geetikakay
Copy link
Copy Markdown
Contributor

@geetikakay geetikakay commented May 22, 2026

What this PR does / why we need it:

Add optional data_source_names filter so callers can limit verification
to specific DataSources.

Which issue(s) this PR fixes:

Filtering unwanted datasources like custom ones without any imagestream. This should be seen as a w/a only.

Special notes for reviewer:
jira-ticket:

More context refer : https://redhat.atlassian.net/browse/CNV-88015

Signed-off-by: Geetika Kapoor <gkapoor@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 577c6857-b749-4cdd-b315-3943a656f1e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (a2dc143) to head (38c7b0e).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4968      +/-   ##
==========================================
- Coverage   98.67%   98.65%   -0.03%     
==========================================
  Files          25       25              
  Lines        2487     2448      -39     
==========================================
- Hits         2454     2415      -39     
  Misses         33       33              
Flag Coverage Δ
utilities 98.65% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rlobillo
Copy link
Copy Markdown
Contributor

/build-and-push-container

@openshift-virtualization-qe-bot-5
Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-4968 published

rlobillo added a commit to rlobillo/openshift-virtualization-tests that referenced this pull request May 28, 2026
Allow callers to limit DataSource verification to a specific set,
skipping custom DataSources without imagestreams.

Ref: RedHatQE#4968

Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
rlobillo added a commit to rlobillo/openshift-virtualization-tests that referenced this pull request Jun 2, 2026
Allow callers to limit DataSource verification to a specific set,
skipping custom DataSources without imagestreams.

Ref: RedHatQE#4968

Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ramón Lobillo <rlobillo@redhat.com>
@geetikakay
Copy link
Copy Markdown
Contributor Author

closing because we have #4983

@geetikakay geetikakay closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants