Skip to content

Increase VolumeSnapshot wait timeout from 240s to 6 minutes #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ahmad-Hafe wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −6
Open

Increase VolumeSnapshot wait timeout from 240s to 6 minutes #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/storage/test_data_import_cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
from utilities.constants import (
BIND_IMMEDIATE_ANNOTATION,
OUTDATED,
QUARANTINED,
TIMEOUT_1MIN,
TIMEOUT_3MIN,
TIMEOUT_5SEC,
Expand Down Expand Up @@ -209,10 +208,6 @@ def second_object_cleanup(
resource_class(namespace=namespace.name, name=second_object_name).clean_up()


@pytest.mark.xfail(
reason=f"{QUARANTINED}: Volume snapshot fails to become ready during test setup. Tracked in CNV-75955",
run=False,
)
@pytest.mark.gating
@pytest.mark.polarion("CNV-7602")
@pytest.mark.s390x
Expand Down
2 changes: 1 addition & 1 deletion utilities/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ def wait_for_volume_snapshot_ready_to_use(namespace, name):
ready_to_use_status = "readyToUse"
LOGGER.info(f"Wait for VolumeSnapshot '{name}' in '{namespace}' to be '{ready_to_use_status}'")
volume_snapshot = VolumeSnapshot(namespace=namespace, name=name)
volume_snapshot.wait()
volume_snapshot.wait(timeout=TIMEOUT_6MIN)
Copy link
Collaborator

@rnetser rnetser Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

increasing the timeout by 2 minutes on a test which failed a month ago and the failure could not be reproduced is odd to me

@jpeimer @dalia-frank wdyt?

Copy link
Contributor Author

@Ahmad-Hafe Ahmad-Hafe Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rnetser I agree
my first approach was to simply just unquarantined the test after hunders of tries to reproduce.

I added 2 min just because in the must-gather I saw the the PVC took it around 5 min to provisin, so I considered that and raised the time up to 6 min in total (+1 plus to volumesnapshot)

@jpeimer @dalia-frank
please tell wdyt?

try:
for sample in TimeoutSampler(
wait_timeout=TIMEOUT_5MIN,
Expand Down
Loading