Increase VolumeSnapshot wait timeout from 240s to 6 minutes

[Ahmad-Hafe]

Short description:

Increase VolumeSnapshot wait timeout from 240s to 6 minutes

More details:

The wait_for_volume_snapshot_ready_to_use() function in uses the default 240-second timeout from This timeout is occasionally insufficient, there is scanrio where pvc took 5M to Provisioning

here is example from must-gther:
Normal Provisioning 4m55s openshift-storage.rbd.csi.ceph.com_openshift-storage.rbd.csi.ceph.com-ctrlplugin-8c7b79947-qlnlf_bc7ddaa7-a128-4f50-a36f-4d8473bb12dd External provisioner is provisioning volume for claim "test-data-import-cron/prime-bb044725-2764-40fd-b6d9-3c918131fefa"

Normal ProvisioningSucceeded 4m55s openshift-storage.rbd.csi.ceph.com_openshift-storage.rbd.csi.ceph.com-ctrlplugin-8c7b79947-qlnlf_bc7ddaa7-a128-4f50-a36f-4d8473bb12dd Successfully

What this PR does / why we need it:

Changes volume_snapshot.wait() to volume_snapshot.wait(timeout=TIMEOUT_6MIN)
Fixes flaky test test_data_import_cron_garbage_collection which fails ~1-2 times in the last month

Which issue(s) this PR fixes:

Fixes flaky test failure in test_data_import_cron_garbage_collection where TimeoutExpiredError: Timed Out: 240 occurs during VolumeSnapshot creation.

Special notes for reviewer:

please see the must-gather in jira card (attached)

jira-ticket:

https://issues.redhat.com/browse/CNV-75955

Summary by CodeRabbit

• Bug Fixes

  • Extended timeout duration for volume snapshot readiness operations to six minutes, improving reliability during snapshot verification processes.

• Tests

  • Re-enabled storage data import test by removing expected failure status and quarantine restrictions.

[openshift-virtualization-qe-bot]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (approvers only)
• /hold cancel - Unblock PR merging
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No WIP, hold, conflict labels
5. Verified: PR must be marked as verified (if verification is enabled)

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• jpeimer
• myakove
• rnetser
• vsibirsk

Reviewers:

• Ahmad-Hafe
• RoniKishner
• dalia-frank
• dshchedr
• duyanyan
• geetikakay
• josemacassan
• jpeimer
• kgoldbla
• kshvaika
• rnetser
• stesrn
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is automatically removed on each new commit
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

[Ahmad-Hafe]

/build-and-push-container

[josemacassan]

/lgtm

[coderabbitai]

📝 Walkthrough

Walkthrough

Two distinct changes address test reliability and timeout configuration: removal of an expected-failure marker from a data import test, and introduction of an explicit six-minute timeout for volume snapshot operations.

Changes

Cohort / File(s)	Summary
Test Cleanup tests/storage/test_data_import_cron.py	Removed QUARANTINED constant from imports and deleted xfail decorator block, indicating the previously failing test is now expected to pass.
Timeout Configuration utilities/storage.py	Added explicit timeout parameter (timeout=TIMEOUT_6MIN) to VolumeSnapshot.wait() call in wait_for_volume_snapshot_ready_to_use(), replacing reliance on default timeout with a six-minute duration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description contains a critical inconsistency: the short description and objectives state the timeout increases to '6 minutes' (360s), but the PR title and commit message state 'to3360 minutes' (201,600s), creating ambiguity about the actual intended change.	Clarify the intended timeout value. If 6 minutes (360s) is correct, update the PR title and commit message to reflect '360 seconds' or '6 minutes'. Verify that TIMEOUT_6MIN constant equals 360 seconds, not 3360 minutes. If 3360 minutes was intended, explain why such an extreme timeout is necessary.
Title check	⚠️ Warning	The title contains a typo: it states '6 minutes' but the commit message and PR description show 'to3360 minutes', which contradicts the stated intent of 6 minutes (360 seconds).	Correct the title to accurately reflect the actual timeout value: either 'Increase VolumeSnapshot wait timeout from 240s to 360s' or clarify the intended duration if 3360 minutes is intentional.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@utilities/storage.py`:
- Line 1034: Replace the use of the timeout constant with an explicit numeric
value: change the call to volume_snapshot.wait(timeout=TIMEOUT_6MIN) so it
passes the literal integer 360 instead of TIMEOUT_6MIN; update the invocation of
volume_snapshot.wait to timeout=360 to follow the repo convention and keep the
rest of the call intact.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cff796e and f0f1ab4.

📒 Files selected for processing (2)

• tests/storage/test_data_import_cron.py
• utilities/storage.py

💤 Files with no reviewable changes (1)

• tests/storage/test_data_import_cron.py

[openshift-virtualization-qe-bot-4]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:pr-3972 published

[Ahmad-Hafe]

/verified

re-run the test 100 times consecutively using --repeat-scope=session --count=100
on psi and bare-metal
pass rate 100%

[openshift-virtualization-qe-bot-3]

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

1. Examine code changes in each modified file
2. Identify affected code paths, functions, and classes
3. Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
4. Trace test dependencies through imports, shared utilities, and fixture inheritance
5. Detect new tests introduced in the PR
6. Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
   • Changes to files/functions used by tests marked with @pytest.mark.smoke
   • Changes to fixtures or utilities imported by smoke tests
   • Changes to conftest.py files that may affect smoke test execution
   • Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

• Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
• path/to/test_file.py - When the entire test file needs verification
• path/to/test_file.py::TestClass::test_method - When specific test(s) needed
• path/to/test_file.py::test_function - When specific test(s) needed
• -m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

• Include only tests directly affected by the changes
• Use a full file path only if ALL tests in that file require verification
• Use file path + test name if only specific tests are needed
• If a test marker can cover multiple files/tests, provide the marker
• Balance coverage vs over-testing - Keep descriptions minimal

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

• Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
• Test Plan: MUST verify both WITH and WITHOUT hardware:
  • Run affected tests on cluster WITH hardware
  • Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

1. YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
2. THEN STOP IMMEDIATELY - Do NOT generate any additional response
3. FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
4. SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

• ❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
• ❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
• ❌ Do NOT add any follow-up comments after submitting the review
• ❌ Do NOT reply to confirm task completion
• ❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

[Ahmad-Hafe]

we have already TIMEOUT_6MIN
in the file being used in 'wait_for_succeeded_dv' function
using TIMEOUT_6MIN is better idea

[coderabbitai]

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash

# Get the diff for both changed files
echo "=== DIFF for utilities/storage.py ==="
git diff origin/main...HEAD -- utilities/storage.py

echo -e "\n=== DIFF for tests/storage/test_data_import_cron.py ==="
git diff origin/main...HEAD -- tests/storage/test_data_import_cron.py

# Find the actual function implementation
echo -e "\n=== wait_for_volume_snapshot_ready_to_use function ==="
ast-grep --pattern $'def wait_for_volume_snapshot_ready_to_use($$$) {
  $$$
}'

# Check for smoke tests that might use storage utilities
echo -e "\n=== Smoke tests in storage area ==="
rg "pytest.mark.smoke" tests/storage/ --type=py -C2

# Check if any smoke tests import from utilities.storage
echo -e "\n=== Smoke tests importing utilities.storage ==="
rg "pytest.mark.smoke" --type=py -B20 | grep -A20 "from utilities.storage"

# Check all smoke tests
echo -e "\n=== All smoke tests in repository ==="
rg "pytest.mark.smoke" --type=py -l

# Check if wait_for_volume_snapshot_ready_to_use is used in smoke tests
echo -e "\n=== Usage of wait_for_volume_snapshot_ready_to_use ==="
rg "wait_for_volume_snapshot_ready_to_use" --type=py -n

Length of output: 4175

---

🏁 Script executed:

#!/bin/bash

# Check if test_cached_snapshots.py has any smoke tests
echo "=== Checking test_cached_snapshots.py for smoke markers ==="
rg "pytest.mark.smoke" tests/storage/golden_image/test_cached_snapshots.py -C3

# Get the test functions in test_cached_snapshots.py
echo -e "\n=== Test functions in test_cached_snapshots.py ==="
rg "^def test_" tests/storage/golden_image/test_cached_snapshots.py -n

# Get the test functions in test_data_import_cron.py
echo -e "\n=== Test functions in test_data_import_cron.py ==="
rg "^def test_" tests/storage/test_data_import_cron.py -n

# Get first 10 lines of each changed file for posting inline comment
echo -e "\n=== First lines of utilities/storage.py ==="
head -n 20 utilities/storage.py

echo -e "\n=== First lines of tests/storage/test_data_import_cron.py ==="
head -n 20 tests/storage/test_data_import_cron.py

Length of output: 1813

---

🏁 Script executed:

#!/bin/bash

# Get PR details and commit SHA
PR_NUMBER=3972
REPO="RedHatQE/openshift-virtualization-tests"

# Get the latest commit SHA from the PR
COMMIT_SHA=$(gh pr view $PR_NUMBER --repo $REPO --json headRefOid --jq '.headRefOid')

echo "PR: $PR_NUMBER"
echo "Commit SHA: $COMMIT_SHA"

# Post inline review comment on the first changed line
# File: utilities/storage.py, Line: 1034 (the changed line with timeout=TIMEOUT_6MIN)

gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/$REPO/pulls/$PR_NUMBER/reviews" \
  -f event='COMMENT' \
  -f commit_id="$COMMIT_SHA" \
  -f comments[][path]='utilities/storage.py' \
  -f comments[][line]=1034 \
  -f comments[][side]='RIGHT' \
  -f comments[][body]='## Test Execution Plan

**Run smoke tests: False**

**Rationale:** No smoke tests depend on `wait_for_volume_snapshot_ready_to_use()`. Verified by tracing all usages—only non-smoke tests in `test_data_import_cron.py` and `test_cached_snapshots.py` use this function.

**Tests to Execute:**

- `tests/storage/test_data_import_cron.py::test_data_import_cron_garbage_collection` - Directly affected: xfail decorator removed and timeout increased from 240s to 6 minutes
- `tests/storage/golden_image/test_cached_snapshots.py` - Uses `wait_for_volume_snapshot_ready_to_use()` which now has increased timeout

**Note:** PR author has already verified the fix with 100 consecutive test runs (100% pass rate) on PSI and bare-metal clusters.'

echo "Review comment posted successfully"

Length of output: 373

---

🏁 Script executed:

#!/bin/bash

# Get PR details and commit SHA
PR_NUMBER=3972
REPO="RedHatQE/openshift-virtualization-tests"

# Get the latest commit SHA from the PR
COMMIT_SHA=$(gh pr view $PR_NUMBER --repo $REPO --json headRefOid --jq '.headRefOid')

echo "PR: $PR_NUMBER"
echo "Commit SHA: $COMMIT_SHA"

# Post inline review comment on the first changed line with correct field types
gh api \
  --method POST \
  -H "Accept: application/vnd.github+json" \
  -H "X-GitHub-Api-Version: 2022-11-28" \
  "/repos/$REPO/pulls/$PR_NUMBER/reviews" \
  -f event='COMMENT' \
  -f commit_id="$COMMIT_SHA" \
  -f comments[][path]='utilities/storage.py' \
  -F comments[][line]=1034 \
  -f comments[][side]='RIGHT' \
  -f comments[][body]='## Test Execution Plan

**Run smoke tests: False**

**Rationale:** No smoke tests depend on `wait_for_volume_snapshot_ready_to_use()`. Verified by tracing all usages—only non-smoke tests in `test_data_import_cron.py` and `test_cached_snapshots.py` use this function.

**Tests to Execute:**

- `tests/storage/test_data_import_cron.py::test_data_import_cron_garbage_collection` - Directly affected: xfail decorator removed and timeout increased from 240s to 6 minutes
- `tests/storage/golden_image/test_cached_snapshots.py` - Uses `wait_for_volume_snapshot_ready_to_use()` which now has increased timeout

**Note:** PR author has already verified the fix with 100 consecutive test runs (100% pass rate) on PSI and bare-metal clusters.'

Length of output: 1797

---

---

🧠 Learnings used

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: For PR `#1904` test execution, the critical validation point is test_connectivity_over_migration_between_localnet_vms which should fail gracefully on cloud clusters but pass on bare-metal/PSI clusters, representing the core nmstate conditional logic functionality.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3196
File: tests/network/upgrade/test_upgrade_network.py:4-4
Timestamp: 2025-12-22T16:27:44.327Z
Learning: For PRs that remove test cases (especially redundant test cleanup PRs in openshift-virtualization-tests), test collection verification (pytest --collect-only showing selected/deselected counts) is sufficient to confirm the removal was clean and the test module remains functional. Full test execution is not required for test deletion PRs.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

---

Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3612
File: tests/network/user_defined_network/ip_specification/test_ip_specification.py:10-10
Timestamp: 2026-01-26T20:29:54.623Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when introducing STD (Standard Test Definition) PRs that define test case structure without implementation, it's acceptable and intentional to use `__test__ = False` to block pytest collection until the tests are fully implemented in a follow-up PR. The STD workflow involves: (1) defining test structure, markers, and documentation first, (2) implementing the actual test logic and removing the collection blocker in a subsequent PR.

---

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

---

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

---

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:26.819Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers to avoid nitpicky style changes (e.g., removing `.keys()` from dict membership checks) because verifying every change is expensive. Be cautious about suggesting low-impact stylistic improvements that require verification overhead.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

---

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

---

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3873
File: tests/network/localnet/test_non_udn_localnet.py:7-9
Timestamp: 2026-02-25T10:52:09.679Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, networking infrastructure requirements such as nmstate, localnet bridge mappings, and NIC availability are NOT considered special/platform-specific infrastructure that would warrant a tier3 marker. These are standard test environment capabilities in this repository's test environment, and tests requiring them do not automatically qualify as tier3 unless they involve other truly platform-specific/complex/time-consuming characteristics beyond standard network test infrastructure.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:83-97
Timestamp: 2025-06-23T19:19:31.961Z
Learning: In OpenShift Virtualization mass machine type transition tests, the kubevirt_api_lifecycle_automation_job requires cluster-admin privileges to function properly, as confirmed by the test maintainer akri3i.

---

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the 2-minute timeout (TIMEOUT_2MIN) is sufficient for the kubevirt_api_lifecycle_automation_job because it only tests with one VM at a time, not multiple VMs simultaneously.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (84584c3) to head (f0f1ab4).
⚠️ Report is 41 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3972      +/-   ##
==========================================
+ Coverage   98.56%   98.59%   +0.03%     
==========================================
  Files          25       25              
  Lines        2297     2357      +60     
==========================================
+ Hits         2264     2324      +60     
  Misses         33       33              

Flag	Coverage Δ
utilities	98.59% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rnetser]

increasing the timeout by 2 minutes on a test which failed a month ago and the failure could not be reproduced is odd to me

@jpeimer @dalia-frank wdyt?

[Ahmad-Hafe]

@rnetser I agree
my first approach was to simply just unquarantined the test after hunders of tries to reproduce.

I added 2 min just because in the must-gather I saw the the PVC took it around 5 min to provisin, so I considered that and raised the time up to 6 min in total (+1 plus to volumesnapshot)

@jpeimer @dalia-frank
please tell wdyt?

[kshvaika]

/lgtm