Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Conversation

@Ashwolaa
Copy link
Contributor

@Ashwolaa Ashwolaa commented Nov 3, 2025

PR related to #124

The compareStruct/compareValues do not consider the parent in the boolean output.
The reason for it was to follow the structure of the getValues from pyqtgraph in the getOpts/getStruct methods.

This PR adds the keyword with_self to the compareParameters/compareValuesParameter to take into account the opts/values of the parent parameter in the boolean output.

The default value of with_self is True which means that parent is considered as default behavior.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.30%. Comparing base (06e8e2c) to head (853a024).
⚠️ Report is 4 commits behind head on 5.0.x_dev.

Additional details and impacted files
@@              Coverage Diff              @@
##           5.0.x_dev     #125      +/-   ##
=============================================
+ Coverage      64.28%   64.30%   +0.01%     
=============================================
  Files             73       73              
  Lines           9181     9185       +4     
=============================================
+ Hits            5902     5906       +4     
  Misses          3279     3279              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@seb5g seb5g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know if this induce a breaking change in pymodaq? Could you check the use case of these methods within pymodaq?

@Ashwolaa
Copy link
Contributor Author

Ashwolaa commented Nov 3, 2025

I checked and did not see a direct use of these methods in pymodaq.

The tests do not seem affected by it.

@seb5g seb5g merged commit f6b67fb into PyMoDAQ:5.0.x_dev Nov 3, 2025
26 of 28 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants