This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Adding comparison of parent in compareStructure/compareValues #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR related to #124
The compareStruct/compareValues do not consider the parent in the boolean output.
The reason for it was to follow the structure of the getValues from pyqtgraph in the getOpts/getStruct methods.
This PR adds the keyword with_self to the compareParameters/compareValuesParameter to take into account the opts/values of the parent parameter in the boolean output.
The default value of with_self is True which means that parent is considered as default behavior.